Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Simplify gce inventory plugin injector #3754
Merged
Conversation
|
Build failed.
|
| @@ -18,8 +18,6 @@ def gce(cred, env, private_data_dir): | |||
| project = cred.get_input('project', default='') | |||
| username = cred.get_input('username', default='') | |||
|
|
|||
| env['GCE_EMAIL'] = username | |||
| env['GCE_PROJECT'] = project | |||
AlanCoding
Apr 23, 2019
Author
Member
See https://docs.ansible.com/ansible/latest/modules/gce_module.html
I can find no evidence that these are employed by the gce module anywhere, and if not, they shouldn't be here.
See https://docs.ansible.com/ansible/latest/modules/gce_module.html
I can find no evidence that these are employed by the gce module anywhere, and if not, they shouldn't be here.
AlanCoding
Apr 23, 2019
Author
Member
b) GCE_PROJECT, GCE_CREDENTIAL_FILE_PATH, GCE_EMAIL (legacy, not recommended; req'd if using p12 key)
Maybe I'm wrong about this and GCE_EMAIL is still needed...
b) GCE_PROJECT, GCE_CREDENTIAL_FILE_PATH, GCE_EMAIL (legacy, not recommended; req'd if using p12 key)
Maybe I'm wrong about this and GCE_EMAIL is still needed...
This consumes the change made in Ansible core ansible/ansible#54407 which is in Ansible 2.8, allowing the plugin injection logic to share the script logic and to be simplified
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
merged commit f608570
into
ansible:devel
2 checks passed
shanemcd
pushed a commit
to shanemcd/awx
that referenced
this pull request
Sep 13, 2019
Upload directly 353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SUMMARY
This consumes the change made in Ansible core:
ansible/ansible#54407
Which is in Ansible 2.8
This allows the plugin injection logic to share the script logic.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
This entry becomes congruent with the script environment now, see:
awx/awx/main/tests/data/inventory/scripts/gce/env.json
Line 4 in 864fef4
This is a very subtle change which will keep open many important possibilities if #3749 also makes it in.
build_envmethods access to the credential file paths