Replace "DOS box" with "command prompt window" and link to Windows FAQ.#12390
Merged
ned-deily merged 1 commit intopython:masterfrom Mar 24, 2019
Merged
Replace "DOS box" with "command prompt window" and link to Windows FAQ.#12390ned-deily merged 1 commit intopython:masterfrom
ned-deily merged 1 commit intopython:masterfrom
Conversation
ned-deily
added
docs
zware
approved these changes
Mar 18, 2019
Member
zware
left a comment
zware
left a comment
There was a problem hiding this comment.
The change itself LGTM, but there's more out of date around it.
| @@ -26,7 +26,7 @@ popular alternative location.) | |||
| On Windows machines, the Python installation is usually placed in | |||
| :file:`C:\\Python36`, though you can change this when you're running the | |||
Member
There was a problem hiding this comment.
No. Currently, the python dir is put, I believe, in Program Files or Program Files (x86) for all users install or somewhere hidden in Appdate for user install. I am not sure what to substitute.
Member
Author
There was a problem hiding this comment.
I don't have the Windows experience to suggest a better wording so I'll leave it to someone else to write a PR to address that.
Contributor
|
Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-12525 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 24, 2019
(cherry picked from commit 6661c17) Co-authored-by: Ned Deily <nad@python.org>
miss-islington
added a commit
that referenced
this pull request
Mar 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Inspired by PR #10703)