Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[Hyper-cli] embed hpm #2375
Conversation
chabou
added some commits
Oct 9, 2017
chabou
added
the
👩🔬 Status: In Progress
label
Oct 18, 2017
chabou
added this to the 2.0.0 milestone
Oct 18, 2017
chabou
added some commits
Oct 18, 2017
chabou
added some commits
Nov 2, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
peterfraedrich
commented
Nov 9, 2017
|
I've submitted a PR for |
This comment has been minimized.
This comment has been minimized.
|
I can't add reviewers but I nominate @albinekb :) |
This comment has been minimized.
This comment has been minimized.
htkoca
commented
Nov 26, 2017
•
|
Instead of going to the path in the first argument, can it be a command? hyper Alternatively, use a flag argument. EX: `hyper --run "ls ~/". It might be out of scope with the current pull request though, but it's something to think about. |
albinekb
reviewed
Nov 27, 2017
| const args = require('args'); | ||
| const chalk = require('chalk'); | ||
| const opn = require('opn'); | ||
| // const columnify = require('columnify'); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
albinekb
reviewed
Nov 27, 2017
| return true; | ||
| } | ||
| let msg = chalk.red(`Error! Config file not found: ${api.configPath}\n`); | ||
| msg += 'Please launch Hyper and retry.'; |
This comment has been minimized.
This comment has been minimized.
albinekb
Nov 27, 2017
Contributor
const message = `
${chalk.red(`Error! Config file not found: ${api.configPath}`)}
Please launch Hyper and retry.
`
This comment has been minimized.
This comment has been minimized.
albinekb
Nov 27, 2017
Contributor
Should we add an issue to make the cli ask to create the file if it does not exists?
This comment has been minimized.
This comment has been minimized.
chabou
Nov 27, 2017
Author
Collaborator
Yes.
Config creation should remain an Hyper task. And yes, we should improve this automatic creation. But this is not a blocker. Most of case, config file will be present.
This comment has been minimized.
This comment has been minimized.
albinekb
reviewed
Nov 27, 2017
| reject(err); | ||
| return; | ||
| } | ||
| // C:\Users\<user>\AppData\Local\hyper\app-2.0.4\resources\bin |
This comment has been minimized.
This comment has been minimized.
albinekb
Nov 27, 2017
Contributor
// C:\Users\<user>\AppData\Local\hyper\app-<version>\resources\bin
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
albinekb
reviewed
Nov 27, 2017
| @@ -0,0 +1,112 @@ | |||
| const fs = require('fs'); | |||
| const os = require('os'); | |||
| const npmName = () => Promise.resolve(); //require('npm-name'); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chabou
Nov 27, 2017
Author
Collaborator
I hoped that this PR would have been merged sooner: dominictarr/rc#94
This comment has been minimized.
This comment has been minimized.
albinekb
reviewed
Nov 27, 2017
| process.exit(1); | ||
| }); | ||
| /* | ||
| const lsRemote = () => { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chabou
Nov 27, 2017
Author
Collaborator
It will be reactivated when NPM API request (URL and criteria) will be chosen.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@htkoca thank you for your feedback. You're right. Passing command could be very usefull. Imo, I prefer command as an option like your |
chabou
added some commits
Jan 9, 2018
This comment has been minimized.
This comment has been minimized.
|
For |
albinekb
approved these changes
Jan 9, 2018
chabou
merged commit 5700690
into
zeit:canary
Jan 9, 2018
bgw
added a commit
to bgw/hyper
that referenced
this pull request
Jan 12, 2018
bgw
referenced this pull request
Jan 12, 2018
Merged
Make CLI perform static analysis of config lazily #2593
amckinlay
reviewed
Apr 26, 2018
| @@ -5,6 +5,9 @@ NAME="Hyper" | |||
| HYPER_PATH="$(dirname "$(dirname "$(dirname "$(realpath "$0")")")")" | |||
| ELECTRON="$HYPER_PATH/$NAME.exe" | |||
| if grep -q Microsoft /proc/version; then | |||
| echo "Warning! Due to WSL limitations, you can use CLI commands here. Please use Hyper CLI on cmd, PowerShell or GitBash/CygWin." | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
amckinlay
commented
Apr 26, 2018
|
@chabou I left a comment about the language of the warning message in As an aside, I wonder why my comment was on an outdated commit. |
chabou
deleted the
chabou:embed_hpm
branch
Apr 27, 2018
This comment has been minimized.
This comment has been minimized.
|
Yes this is a typo. |

chabou commentedOct 18, 2017
•
edited
This PR has PR #2342 already merged into it.
Next steps:
Hyper CLIto create a new instance ofHyperif it is already launched. It should act the same way that launching Hyper twice by icon.Hyperand not install/uninstall/list plugins due to Env var problem: see microsoft/WSL#1494Bonus:
hyper <path>should open Hyper in this pathScreencast:
