Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 31 million developers.
Sign up
Pinned
3,196 contributions in the last year
Activity overview
Contribution activity
April 2019
Created a pull request in electron/electronjs.org that received 4 comments
fix: persist cookie for language choice
Fixes #2394. Adds back a max cookie age so that the language choice isn't forgotten after browser is closed and reopened.
+1
−0
•
4
comments
- docs: note desktop audio limitation on macOS
- refactor: make name a prop on app
- fix: crash when passing empty string to recording
- [wip] feat: allow optional activation of app windows on show
- [wip] test: workaround for nested describe skips
- test: remove non-applicable processMemoryInfo specs
- fix: process.getProcessMemoryInfo not being exposed to sandbox renderers
- build: fix spec-main linting for 'only'
- fix: report module name when require fails in sandboxed renderers
- fix: crash when passing empty string to recording (backport: 5-0-x)
- test: remove non-applicable processMemoryInfo specs (backport: 5-0-x)
- fix: report module name when require fails in sandboxed renderers
- fix: report module name when require fails in sandboxed renderers
- fix: re-entracy problem with InvalidateFrameSinkId().
- fix: crashes in RenderFrameImpl::OnSelectPopupMenuItem(s)
- build: optionally exclude some parts of patches from being applied (backport: 4-1-x)
- build: optionally exclude some parts of patches from being applied (backport: 5-0-x)
- chore: bump chromium to 73.0.3683.104 (5-0-x)
- [wip] feat: allow optional activation of app windows on show
- fix: port OSR code to new viz compositor codepath (backport: 5-0-x)
- fix: port OSR code to new viz compositor codepath
- fix: make devtools extensions load correctly
- docs: clarify cookie domain normalization (backport: 4-1-x)
- docs: clarify cookie domain normalization (backport: 5-0-x)
- build: auto-generate the browserify step GN inputs
4
contributions
in private repositories
Apr 3 – Apr 5