Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Doc/requirements.txt for Read the Docs build #260
Conversation
encukou
force-pushed the
encukou:doc-requirements
branch
from
365f0dc
to
c07c9ac
Jan 30, 2019
encukou
referenced this pull request
Jan 30, 2019
Open
Doc: Clarify and improve documentation of ldap.ldapobject.LDAPObject #261
This comment has been minimized.
This comment has been minimized.
|
I made a private docs build to verify this solves the problem. |
encukou
merged commit 7fb02c0
into
python-ldap:master
Jan 30, 2019
3 of 4 checks passed
encukou
deleted the
encukou:doc-requirements
branch
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
encukou commentedJan 30, 2019
The documentation build uses docstrings from the code, and so it needs the code to be importable.
We already use a fake _ldap module for cases where the C compiler is not available, like on Read the Docs.
Another issue on Read the Docs is that the
pyasn1dependency needs to be installed. This can't be done automatically via setup.py install, as that would attempt to build C code.Instead, add a documentation-only "requirements.txt", which we can point Read the Docs to.