New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify generation of launch.json with prompts #3745

Merged

DonJayamanne merged 10 commits into Microsoft:master from DonJayamanne:issue3321Launch

Dec 20, 2018

DonJayamanne commented Dec 18, 2018 •

edited

Requires #3742

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Unit tests & system/integration tests are added/updated
Test plan is updated as appropriate
package-lock.json has been regenerated by running npm install (if dependencies have changed)

DonJayamanne added some commits Dec 18, 2018


      Rename folder

83169f4


      Refactor debug configuration provider

c420628


      refactor config and labels

10f8b7c


      Revert config

2d040e6

DonJayamanne changed the title Simplify generation of launch.json with prompts WIP - Simplify generation of launch.json with prompts Dec 18, 2018

DonJayamanne added some commits Dec 18, 2018


      Add prompts

2ca5fbc


      Merged master

9d64778

DonJayamanne force-pushed the DonJayamanne:issue3321Launch branch from `3f85a82` to `9d64778` Dec 19, 2018

DonJayamanne closed this Dec 19, 2018

DonJayamanne reopened this Dec 19, 2018

DonJayamanne closed this Dec 19, 2018

DonJayamanne reopened this Dec 19, 2018

DonJayamanne added some commits Dec 20, 2018


      Add tests

37a6289


      News entry

22ee97d

DonJayamanne force-pushed the DonJayamanne:issue3321Launch branch from `f0ab415` to `22ee97d` Dec 20, 2018

DonJayamanne changed the title WIP - Simplify generation of launch.json with prompts Simplify generation of launch.json with prompts Dec 20, 2018

DonJayamanne added some commits Dec 20, 2018


      add telemetry

c753e94


      Simplify

8ba770f

d3r3kk approved these changes Dec 20, 2018

View changes

d3r3kk left a comment

This is a great change, going to help the users just getting up and running with VS Code.

One question in there about naming (localization) but otherwise looks good.

Show resolved Hide resolved src/client/common/utils/localize.ts

DonJayamanne merged commit `444befa` into Microsoft:master Dec 20, 2018
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress

Details

license/cla All CLA requirements met.

Details

vscode-python-ci-pr_validation #20181220.5 succeeded

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.