Skip to content

/vscode-python forked from DonJayamanne/pythonVSCode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snippet for `if __name__ == "__main__":` block #2881

Merged
merged 6 commits into from Oct 17, 2018

Conversation

Reviewers

@brettcannon brettcannon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rsnk96 @msftclas @brettcannon
@rsnk96
Copy link

rsnk96 commented Oct 14, 2018 •
edited

Added snippet to check if program is being run directly or imported without a separate main() function. (To address #2242 )

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

rsnk96 added some commits Oct 13, 2018

@rsnk96
Add snippet for #2242 
Added snippet to check if program is being run directly or imported without a separate `main()` function (#2242)
7d5ed8f
@rsnk96
Added news entry
Loading status checks…
5aca411
@msftclas

This comment has been minimized.

Sign in to view
Copy link

msftclas commented Oct 14, 2018 •
edited

CLA assistant check
All CLA requirements met.
@brettcannon

brettcannon requested changes Oct 16, 2018
View changes

Copy link
Member

brettcannon left a comment

Some very minor format tweaks.
Show resolved Hide resolved snippets/python.json Outdated
Show resolved Hide resolved snippets/python.json Outdated
Show resolved Hide resolved snippets/python.json Outdated
Show resolved Hide resolved snippets/python.json Outdated

brettcannon added some commits Oct 17, 2018

@brettcannon @rsnk96
Replace tab with space indentation
Loading status checks…
189c5f6
@brettcannon @rsnk96
Changed description of snippet
Loading status checks…
9fbca7e
@brettcannon @rsnk96
maintained double quotes
Loading status checks…
f326d21

@rsnk96 rsnk96 changed the title Add snippet for `if __name__ == '__main__':` block Add snippet for `if __name__ == "__main__":` block Oct 17, 2018

@rsnk96
Removed old main snippet
Loading status checks…
4cecef3
@rsnk96

This comment has been minimized.

Sign in to view
Copy link
Author

rsnk96 commented Oct 17, 2018

Updated @brettcannon
@brettcannon

brettcannon approved these changes Oct 17, 2018
View changes

@brettcannon brettcannon merged commit 942f544 into Microsoft:master Oct 17, 2018
3 checks passed

3 checks passed

VSCode-Python-CI #20181017.4 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@brettcannon

This comment has been minimized.

Sign in to view
Copy link
Member

brettcannon commented Oct 17, 2018

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.