New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing steps to build angular #12443

Closed

gary-b opened this issue Oct 21, 2016 · 3 comments

Labels

area: build & ci freq1: low type: bug/fix

Milestone

Contributor

gary-b commented Oct 21, 2016 •

edited

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
There are additional steps required to build angular not included in the developer guide, some of which could be scripted.

a) On Windows / Linux npm install will fail because fsevents requires a mac.

b) On Windows build.sh fails because it tries to create a symlink to the polymer directory and it doesn't exist. This is because the dependency is managed by bower, and bower install is never ran. (The script does not fail on Linux when the directory is missing.)

Expected behavior
I'm planning to submit a PR to:

Provide a script to remove the fsevents dependency when not on a mac and update dev guide to advise running it. (Better solutions welcome...)
Have bower install run automatically when npm install is ran (using the packages.json postinstall step).

Minimal reproduction of the problem with instructions
Install and build on Windows following guide

What is the motivation / use case for changing the behavior?
Make life easier for us noobs.

Please tell us about your environment:
Windows 10, Node v5.12.0, NPM v3.10.8, Bower v1.7.9
LUbuntu 16, Node v5.12.0, NPM 3.10.9

Angular version: 2.0.X
Angular master
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
N/A
Language: [all | TypeScript X.X | ES6/7 | ES5]
N/A
Node (for AoT issues): node --version =
v5.12.0

The text was updated successfully, but these errors were encountered:

gary-b added a commit to gary-b/angular that referenced this issue


          build(fsevents) add script to remove mac dependency

c773d44

The fsevents package is required when building on Mac, but will cause
npm install to fail when building on Windows or Linux. This script
removes the dependency from package.json and shrinkwrap.json. The
developer guide has also been updated.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build(bower) run bower install after npm install

6f6a926

The Polymer dependency is managed by bower, yet the developer guide did
not specify to run bower install. This caused the build.sh script to
fail when setting up symlinks on Windows. Now we run bower install as a
postinstall step when npm install is ran.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build(fsevents) add script to remove mac dependency

d987d17

The fsevents package is required when building on Mac, but will cause
npm install to fail when building on Windows or Linux. The new script
removes the dependency from package.json and shrinkwrap.json. The update
to developer.md advises of its usage.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build(bower) run bower install after npm install

3032c18

The Polymer dependency is managed by bower, yet the developer guide did
not specify to run bower install. This caused the build.sh script to
fail when setting up symlinks on Windows. Now we run bower install as a
postinstall step when npm install is ran.

Partially closes angular#12443

gary-b mentioned this issue

build(fsevents+bower) add script to remove mac dependency + run bower after npm install #12449

Closed

2 tasks

gary-b added a commit to gary-b/angular that referenced this issue


          build(fsevents) add script to remove mac dependency

0ddc09a

The fsevents package is required when building on Mac, but will cause
npm install to fail when building on Windows or Linux. The new script
removes the dependency from package.json and shrinkwrap.json. The update
to developer.md advises of its usage.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build(bower) run bower install after npm install

1b298c7

The Polymer dependency is managed by bower, yet the developer guide did
not specify to run bower install. This caused the build.sh script to
fail when setting up symlinks on Windows. Now we run bower install as a
postinstall step when npm install is ran.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build(fsevents) add script to remove mac dependency

0285fb5

The fsevents package is required when building on Mac, but will cause
npm install to fail when building on Windows or Linux. The new script
removes the dependency from package.json and shrinkwrap.json. The update
to developer.md advises of its usage.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build(bower) run bower install after npm install

e72c24d

The Polymer dependency is managed by bower, yet the developer guide did
not specify to run bower install. This caused the build.sh script to
fail when setting up symlinks on Windows. Now we run bower install as a
postinstall step when npm install is ran.

Partially closes angular#12443

pkozlowski-opensource added the area: build & ci label

gary-b added a commit to gary-b/angular that referenced this issue


          build: add script to remove mac dependency

cad5a92

The fsevents package is required when building on Mac, but will cause
npm install to fail when building on Windows or Linux. The new script
removes the dependency from package.json and shrinkwrap.json. The update
to developer.md advises of its usage.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build: run bower install after npm install

9dbefb2

The Polymer dependency is managed by bower, yet the developer guide did
not specify to run bower install. This caused the build.sh script to
fail when setting up symlinks on Windows. Now we run bower install as a
postinstall step when npm install is ran.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build: add script to remove mac dependency

d856cf7

The fsevents package is required when building on Mac, but will cause
npm install to fail when building on Windows or Linux. The new script
removes the dependency from package.json and shrinkwrap.json. The update
to developer.md advises of its usage.

Partially closes angular#12443

gary-b added a commit to gary-b/angular that referenced this issue


          build: run bower install after npm install

df68eb4

The Polymer dependency is managed by bower, yet the developer guide did
not specify to run bower install. This caused the build.sh script to
fail when setting up symlinks on Windows. Now we run bower install as a
postinstall step when npm install is ran.

Partially closes angular#12443

e-cloud commented Nov 23, 2016

it's not necessary to have a script to change the npm-shrinkwrap.json.

You can run npm i -f to force installation.

Nevertheless, the bower part is worthy. But you dont have to refer the bin path, because npm run script automatically add the bin path to PATH

This was referenced Jan 16, 2017

Unsupported platform for fsevents@1.0.14: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"}) #13935

Closed

fix(build): move fsevents into optionalDependencies #13945

Closed

IgorMinar added freq1: low severity3: broken type: bug/fix labels

ngbot bot added this to the Backlog milestone

Member

gkalpak commented Mar 27, 2019 •

edited

This is now obsolete, as we have moved to a different build toolchain.
(There might still be issues with building on Windows, which we are working on, but the problems mentioned here should not be relevant any more.)

gkalpak closed this as completed

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.