Skip to content

Remove Box from PyObject#722

Merged
OddCoincidence merged 5 commits into
masterfrom
joey/unboxed-payload-2
Mar 23, 2019
Merged

Remove Box from PyObject#722
OddCoincidence merged 5 commits into
masterfrom
joey/unboxed-payload-2

Conversation

@OddCoincidence
Copy link
Copy Markdown
Contributor

@OddCoincidence OddCoincidence commented Mar 23, 2019

No description provided.

@coolreader18
Copy link
Copy Markdown
Member

coolreader18 commented Mar 23, 2019

Ah, it's the same thing again with WASM held_rcs.

@OddCoincidence
Copy link
Copy Markdown
Contributor Author

OddCoincidence commented Mar 23, 2019

I always forget about WASM 😅

coolreader18
coolreader18 reviewed Mar 23, 2019
View reviewed changes
Comment thread wasm/lib/src/vm_class.rs
/// you can put a Rc in here, keep it as a Weak, and it'll be held only for
/// as long as the StoredVM is alive
held_rcs: RefCell<Vec<Rc<dyn HeldRcInner>>>,
held_objects: RefCell<Vec<PyObjectRef>>,
Copy link
Copy Markdown
Member

@coolreader18 coolreader18 Mar 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a better system than what I had. You can just remove HeldRcInner now.

coolreader18
coolreader18 approved these changes Mar 23, 2019
View reviewed changes
Comment thread vm/src/pyobject.rs
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 23, 2019 •
edited
Loading

Codecov Report

Merging #722 into master will increase coverage by 2.74%.
The diff coverage is 50.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   48.32%   51.07%   +2.74%     
==========================================
  Files          81       81              
  Lines       15699    16279     +580     
  Branches     3831     4089     +258     
==========================================
+ Hits         7587     8314     +727     
+ Misses       6315     6110     -205     
- Partials     1797     1855      +58
Impacted Files Coverage Δ
wasm/lib/src/vm_class.rs 0% <0%> (ø) ⬆️
vm/src/vm.rs 69.71% <0%> (+18.89%) ⬆️
vm/src/obj/objweakref.rs 86.95% <100%> (ø) ⬆️
vm/src/obj/objtype.rs 47.7% <50%> (+0.57%) ⬆️
vm/src/pyobject.rs 71.8% <55.31%> (+5.56%) ⬆️
vm/src/obj/objfunction.rs 67.44% <0%> (-6.98%) ⬇️
vm/src/stdlib/string.rs 25% <0%> (-1.75%) ⬇️
vm/src/obj/objcomplex.rs 75.16% <0%> (-0.94%) ⬇️
vm/src/builtins.rs 44.57% <0%> (+0.08%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a7aed...050bf07. Read the comment docs.

@OddCoincidence OddCoincidence merged commit b7fa08e into master Mar 23, 2019
@OddCoincidence OddCoincidence deleted the joey/unboxed-payload-2 branch April 9, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OddCoincidence @coolreader18 @codecov-io