New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump year #28220

Closed

CaerusKaru wants to merge 0 commits into angular:7.2.x from CaerusKaru:adam/year-patch

Member

CaerusKaru commented Jan 18, 2019

Patch version of #27880

CaerusKaru requested review from IgorMinar and as code owners

googlebot added the cla: yes label

Member Author

CaerusKaru commented Jan 18, 2019

cc @jenniferfell

ghost commented Jan 19, 2019

Facebook stripped this out from their headers in a previous commit (facebook/react#13593). Wouldn't this be a bit easier if this was followed here?

Member Author

CaerusKaru commented Jan 21, 2019

Also cc @IgorMinar

jenniferfell added comp: docs docsarea: marketing aio: preview labels

mary-poppins commented Jan 23, 2019

You can preview a17e7c6 at https://pr28220-a17e7c6.ngbuilds.io/.

ngbot bot added this to the needsTriage milestone

Contributor

jenniferfell commented Jan 23, 2019

Facebook stripped this out from their headers in a previous commit (facebook/react#13593). Wouldn't this be a bit easier if this was followed here?

Thanks, but we're going to continue using what's already been approved by Google's legal team.

jenniferfell approved these changes

View changes

Contributor

jenniferfell left a comment

LGTM. @IgorMinar approved #27880 which is exactly the same changes just with a merge target that didn't include patch (stable).

jenniferfell added the target: patch label

Contributor

jenniferfell commented Jan 23, 2019

@petebacondarwin or @gkalpak : Can you approve as docs-infra? Thanks!

petebacondarwin reviewed

View changes

aio/src/app/layout/footer/footer.component.html Outdated Show resolved Hide resolved

petebacondarwin requested changes

View changes

packages/router/README.md Outdated Show resolved Hide resolved

gkalpak reviewed

View changes

aio/src/app/layout/footer/footer.component.html Outdated Show resolved Hide resolved

petebacondarwin approved these changes

View changes

jasonaden reviewed

View changes

Contributor

jasonaden left a comment

For Docs team.

IgorMinar approved these changes

View changes

IgorMinar added PR target: patch-only action: merge action: merge-assistance and removed target: patch labels

Contributor

IgorMinar commented Feb 2, 2019

merge-assistance: this is a patch branch PR - no g3 impact. also pull approve seems stale. please rebase if necessary so that this PR lands.

ericmartinezr mentioned this pull request

copy right details not updated #28511

Closed

alexeagle approved these changes

View changes

Contributor

jenniferfell commented Feb 4, 2019

@CaerusKaru @IgorMinar Heads up: As you probably recall, this PR was specifically to take changes that had already been approved and merged into master, and also apply those same changes to patch (aka stable). Any additional changes made in this PR mean that you'll need to merge into master & patch.

matsko added a commit that referenced this issue


          build: bump year (#28220)

dad1bc7

PR Close #28220

CaerusKaru closed this

CaerusKaru force-pushed the adam/year-patch branch from a17e7c6 to c1aa1bf

CaerusKaru deleted the adam/year-patch branch

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.