Skip to content

refactor: remove extra line break in gulpfile#29358

Closed
sarkiroka wants to merge 3 commits into
angular:masterfrom
sarkiroka:patch-1
Closed

refactor: remove extra line break in gulpfile#29358
sarkiroka wants to merge 3 commits into
angular:masterfrom
sarkiroka:patch-1

Conversation

@sarkiroka
Copy link
Copy Markdown
Contributor

@sarkiroka sarkiroka commented Mar 17, 2019

this is not an ascii art

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

this is not an ascii art
@sarkiroka sarkiroka requested a review from a team March 17, 2019 13:30
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarkiroka the changes LGTM but will need the CLA before merging.

@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Mar 18, 2019
@brandonroberts brandonroberts added comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Mar 19, 2019
@ngbot ngbot Bot added this to the Backlog milestone Mar 19, 2019
@brandonroberts brandonroberts added comp: misc and removed target: patch This PR is targeted for the next patch release comp: docs effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Mar 19, 2019
@ngbot ngbot Bot modified the milestones: Backlog, needsTriage Mar 19, 2019
@brandonroberts brandonroberts added state: blocked comp: docs effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup and removed refactoring Issue that involves refactoring or code-cleanup labels Mar 19, 2019
@ngbot ngbot Bot removed this from the needsTriage milestone Mar 19, 2019
@ngbot ngbot Bot added this to the Backlog milestone Mar 19, 2019
@brandonroberts brandonroberts self-assigned this Mar 19, 2019
Copy link
Copy Markdown
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update git commit message to refactor: remove extra line break in gulpfile

@sarkiroka
Copy link
Copy Markdown
Contributor Author

CLA ok, what is the next?

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sarkiroka sarkiroka changed the title not need two enter separation refactor: remove extra line break in gulpfile Mar 23, 2019
@sarkiroka
Copy link
Copy Markdown
Contributor Author

I create new one: #29489
Can you check it?

@filipesilva
Copy link
Copy Markdown
Contributor

Heya @sarkiroka, lets continue the conversation in #29489.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes effort1: hours refactoring Issue that involves refactoring or code-cleanup risk: low state: blocked state: community Someone from the Angular community is working on this issue or submitted this PR target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants