docs: add note about ngModel usage in structural directives guide by javatutorials2016 · Pull Request #29206 · angular/angular

javatutorials2016 · 2019-03-09T22:18:11Z

When I tried one of the examples provided in the documention, encountered the " Can't bind to 'ngModel' since it isn't a known property of 'select' ” error. So to resolve it I imported the FormsModule in ngModule. If it is mentioned in the documentation, it would be handy for the beginners to try and learn. Thanks for considering.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

When I tried the example, encountered the " Can't bind to 'ngModel' since it isn't a known property of 'select' ” error. So to resolve it I imported the FormsModule in ngModule. If it is mentioned in the documentation, it would be handy for the beginners to try and learn. Thanks for considering.

mary-poppins · 2019-03-11T12:46:09Z

You can preview bbd81d7 at https://pr29206-bbd81d7.ngbuilds.io/.

kapunahelewong

LGTM

brandonroberts · 2019-03-11T13:08:11Z

The git commit message needs to be updated to describe the change also. docs: add note about ngModel usage in structural directives guide

brandonroberts · 2019-03-22T14:57:56Z

@javatutorials2016 are you still interested in landing this change?

javatutorials2016 · 2019-03-22T15:27:47Z

Hi Brandon, yes. Any action pending from my side? Please let me know thanks

…

On Friday, March 22, 2019, Brandon ***@***.***> wrote: @javatutorials2016 <https://github.com/javatutorials2016> are you still interested in landing this change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29206 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASdXxKGfRR5o2HTIE3oibhMMie2hZDj_ks5vZO-7gaJpZM4bm79c> .

Co-Authored-By: javatutorials2016 <javatutorials2016@gmail.com>

googlebot · 2019-03-22T15:49:06Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

javatutorials2016

docs: add note about ngModel usage in structural directives guide

brandonroberts · 2019-03-22T15:54:40Z

Something happened with the CLA. Will you rebase and squash so you're the only author?

javatutorials2016 · 2019-03-22T18:24:51Z

Thanks. Will do as soon as I reach home . At office now thanks

…

On Friday, March 22, 2019, Brandon ***@***.***> wrote: Something happened with the CLA. Will you rebase and squash so you're the only author? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29206 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASdXxFhPLaDzAX9widQvyjRubGkB3DLdks5vZP0HgaJpZM4bm79c> .

javatutorials2016

docs: add note about ngModel usage in structural directives guide

javatutorials2016 · 2019-03-26T14:07:27Z

Hi Brandon, Shall I create a new pull request for the same? I did the changes directly on github portal so when I clone now, I don’t see my changes. Kindly suggest and thanks for your time. John

…

On Friday, March 22, 2019, John Anto ***@***.***> wrote: Thanks. Will do as soon as I reach home . At office now thanks On Friday, March 22, 2019, Brandon ***@***.***> wrote: > Something happened with the CLA. Will you rebase and squash so you're the > only author? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#29206 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ASdXxFhPLaDzAX9widQvyjRubGkB3DLdks5vZP0HgaJpZM4bm79c> > . >

brandonroberts · 2019-03-26T15:27:28Z

@javatutorials2016 if that would be easier for you, then yes just create a new one.

javatutorials2016 · 2019-03-26T16:06:32Z

thanks. Created a new one# 29522

…

On Tue, Mar 26, 2019 at 11:29 AM Brandon ***@***.***> wrote: @javatutorials2016 <https://github.com/javatutorials2016> if that would be easier for you, then yes just create a new one. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29206 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASdXxFHSqYL_rz3LFuDr1myKQzFuOJIeks5vajzjgaJpZM4bm79c> .

angular-automatic-lock-bot · 2019-09-14T21:52:35Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

javatutorials2016 requested a review from a team March 9, 2019 22:18

googlebot added the cla: yes label Mar 9, 2019

javatutorials2016 changed the title ~~docs: describe your change...~~ Note to include FormsModule under ngModule to enable ngModel Mar 9, 2019

ngbot Bot added this to the Backlog milestone Mar 11, 2019

brandonroberts self-assigned this Mar 11, 2019

brandonroberts added area: core Issues related to the framework runtime aio: preview labels Mar 11, 2019

brandonroberts requested a review from kapunahelewong March 11, 2019 12:48

kapunahelewong approved these changes Mar 11, 2019

View reviewed changes

brandonroberts suggested changes Mar 11, 2019

View reviewed changes

Comment thread aio/content/guide/structural-directives.md Outdated

brandonroberts changed the title ~~Note to include FormsModule under ngModule to enable ngModel~~ docs: add note about ngModel usage in structural directives guide Mar 11, 2019

brandonroberts added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 11, 2019

Update aio/content/guide/structural-directives.md

bcaf458

Co-Authored-By: javatutorials2016 <javatutorials2016@gmail.com>

javatutorials2016 commented Mar 22, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes labels Mar 22, 2019

javatutorials2016 commented Mar 22, 2019

View reviewed changes

brandonroberts closed this Mar 29, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

javatutorials2016 commented Mar 9, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented Mar 11, 2019

Uh oh!

kapunahelewong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brandonroberts commented Mar 11, 2019

Uh oh!

brandonroberts commented Mar 22, 2019

Uh oh!

javatutorials2016 commented Mar 22, 2019 via email

Uh oh!

googlebot commented Mar 22, 2019

Uh oh!

javatutorials2016 left a comment

Choose a reason for hiding this comment

Uh oh!

brandonroberts commented Mar 22, 2019

Uh oh!

javatutorials2016 commented Mar 22, 2019 via email

Uh oh!

javatutorials2016 left a comment

Choose a reason for hiding this comment

Uh oh!

javatutorials2016 commented Mar 26, 2019 via email

Uh oh!

brandonroberts commented Mar 26, 2019

Uh oh!

javatutorials2016 commented Mar 26, 2019 via email

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants