Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP_INITIALIZER should also work with observables #15088

Open
DzmitryShylovich opened this issue Mar 11, 2017 · 7 comments · May be fixed by #33222
Open

APP_INITIALIZER should also work with observables #15088

DzmitryShylovich opened this issue Mar 11, 2017 · 7 comments · May be fixed by #33222
Labels
comp: core core: bootstrap feature
Milestone
Backlog

Comments

@DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Mar 11, 2017

I'm submitting a ... (check one with "x")

[x] feature request

Current behavior
APP_INITIALIZER only works with promises.

Expected behavior
Should also work with observables

What is the motivation / use case for changing the behavior?
Consistency with other parts of the framework
DzmitryShylovich added a commit to DzmitryShylovich/angular that referenced this issue Mar 12, 2017
@DzmitryShylovich
feat(core): APP_INITIALIZER should work with observables
8557bf2 
Closes angular#15088
DzmitryShylovich added a commit to DzmitryShylovich/angular that referenced this issue Mar 12, 2017
@DzmitryShylovich
feat(core): APP_INITIALIZER should work with observables
16d1ccb 
Closes angular#15088
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018
@nukec
Copy link

@nukec nukec commented Feb 12, 2019

2 years later.
@TheAifam5
Copy link

@TheAifam5 TheAifam5 commented Mar 18, 2019

hmmmmmmmmmmmmm :D what's the status?
@hevans90
Copy link

@hevans90 hevans90 commented May 21, 2019

This still doesn't seem to work at all 0_0
@johnsnow20087349
Copy link

@johnsnow20087349 johnsnow20087349 commented Jul 19, 2019

2 and a half years later
vthinkxie added a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
6a4fdbc 
close angular#15088
@vthinkxie vthinkxie linked a pull request that will close this issue Oct 17, 2019
Open
5 of 14 tasks complete
vthinkxie added a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
c33c017 
close angular#15088
vthinkxie added a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
ac82f5b 
close angular#15088
vthinkxie added a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
fa6f57d 
close angular#15088
vthinkxie added a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
b77bf85 
close angular#15088
vthinkxie added a commit to vthinkxie/angular that referenced this issue Oct 17, 2019
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
5253a23 
close angular#15088
@vthinkxie
Copy link
Contributor

@vthinkxie vthinkxie commented Oct 23, 2019

I have opened a PR to fix this issue, anyone could check it?
#33222
Closed
@pauldraper
Copy link

@pauldraper pauldraper commented May 1, 2020

User expected this to work: https://stackoverflow.com/questions/47422095/angular-app-initializer-promise-vs-observable
vthinkxie added a commit to vthinkxie/angular that referenced this issue Sep 14, 2020
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
92490df 
add support to observable with APP_INITIALIZER

close angular#15088
vthinkxie added a commit to vthinkxie/angular that referenced this issue Sep 14, 2020
@vthinkxie
feat(core): support APP_INITIALIZER work with observable
da40ee2 
add support to observable with APP_INITIALIZER

close angular#15088
@Thehee
Copy link

@Thehee Thehee commented Dec 18, 2020

3 years later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: core core: bootstrap feature
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

feat(core): support APP_INITIALIZER work with observable
feat(core): APP_INITIALIZER should work with observables
10 participants
@IgorMinar @pkozlowski-opensource @pauldraper @vthinkxie @TheAifam5 @nukec @DzmitryShylovich @hevans90 @johnsnow20087349 @Thehee
You can’t perform that action at this time.