Unity: ignore TextMesh Pro #2988
Conversation
|
@qCring thanks! |
|
@qCring I think this may be incorrect.. While TextMesh Pro has indeed moved to the package manager, the TextMesh Pro folder is still created when importing the "TMP Essential Assets". |
|
@heatblayze if you feel like this should be reverted or changed, I'm open to a PR which helps improve things |
|
sorry for the delayed response! @heatblayze I agree, you are absolutely right I expected all related dependency resources to be managed by Unity's package manager without double-checking. NuGet (or gradle or other comparable tools) perform package-related operations like restore/update/upgrade on the client-side. Dependecies are referenced in some manifest instead of actually pushing files to the VCS. Unfortunately, Unity handles things differently in this case. But this is no excuse, I really should have checked. Sorry for the inconvenience! So yes, this should be reverted! |
@qCring @heatblayze I'm not able to quickly revert this PR (because of subsequent changes to the file) but I'd love to see a PR to close this out now we're on the same page. |
|
@heatblayze do you want to create a PR since you pointed out the issue? |
|
@qCring Sure thing! I'll get onto it now |
Unlike other packages, TextMesh Pro is not entirely managed by Unity's new Package Manager, and still imports some assets directly into the project.
…b#3134) Unlike other packages, TextMesh Pro is not entirely managed by Unity's new Package Manager, and still imports some assets directly into the project.
* upstream/master: Added Simulink cache files (github#3148) Add esp-idf.gitignore (github#3150) Add *.sch-bak to KiCad.gitignore (github#3153) Reference why to exclude binary jar, fixes github#111 (github#3154) Update Autotools.gitignore (github#3005) Improving the documentation of Objective-C and Swift files (github#3133) Ignore gummi previews (github#3144) Swift: ignore .swiftpm (github#3083) Update Godot.gitignore (github#3142) Revert of github#2988. TextMesh Pro files are not auto managed (github#3134) Partial revert of 837181e (github#3132) Added more glossaries auxiliary files and makeindex logs to TeX template (github#3104) .travis.yml: Trim trailing whitespace and indent (github#3118) Add *.hie to Haskell.gitignore (github#3120) Ignore the .ionide working folder (github#3108)
…b#3134) Unlike other packages, TextMesh Pro is not entirely managed by Unity's new Package Manager, and still imports some assets directly into the project.
Reasons for making this change:
TextMesh Pro is fully integrated in Unity since 2017 and all related resources are managed by Unity's Package Manager. So it would make sense to ignore them by default
Links to documentation supporting these rule changes:
Check out the official blog post from early 2017