Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: store onread callback in internal field #26837

Closed
wants to merge 3 commits into from

Conversation

Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
C++ author ready lib / src
Projects
None yet
Milestone
No milestone
5 participants
@addaleax @nodejs-github-bot @bnoordhuis @jasnell @joyeecheung
@addaleax
Copy link
Member

addaleax commented Mar 21, 2019

This gives a slight performance improvement. At 2000 runs:

                                        confidence improvement accuracy (*)   (**)  (***)
net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
src: store onread callback in internal field 
This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
6307c03
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ lib / src labels Mar 21, 2019

@joyeecheung

joyeecheung approved these changes Mar 21, 2019
View changes

Show resolved Hide resolved src/base_object-inl.h Outdated
@jasnell

jasnell approved these changes Mar 21, 2019
View changes

Copy link
Member

jasnell left a comment

Nice. I've been curious about doing something like this. Glad to see there's an actual benefit
@addaleax
fixup! src: store onread callback in internal field
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
6c6817f
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21737/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented Mar 21, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21739/
@bnoordhuis

bnoordhuis approved these changes Mar 21, 2019
View changes

src/base_object-inl.h Outdated
v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<void>& info) {
// This could be e.g. value->IsFunction().
CHECK_IMPLIES(typecheck != nullptr, ((*value)->*typecheck)());

This comment has been minimized.

Sign in to view
Copy link
@bnoordhuis

bnoordhuis Mar 21, 2019

Member

Since typecheck is never nullptr currently, maybe change the CHECK_IMPLIES into a simple CHECK?

You could also remove the default template argument and have a second, single-arg InternalFieldSet() without a check.

This comment has been minimized.

Sign in to view
Copy link
@addaleax

addaleax Mar 26, 2019

Author Member

Yeah, I’ve turned it into a simple CHECK and removed the nullptr default. We can always adjust this if we want.

@joyeecheung joyeecheung referenced this pull request Mar 22, 2019

Open

CI failures: 20190322 #21

@addaleax
fixup! fixup! src: store onread callback in internal field
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
c3ef805

@addaleax addaleax added the author ready label Mar 26, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Mar 26, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21904/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

addaleax commented Mar 26, 2019

Landed in 3018441

@addaleax addaleax closed this Mar 26, 2019

addaleax added a commit that referenced this pull request Mar 26, 2019

@addaleax
src: store onread callback in internal field 
This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: #26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
3018441

@addaleax addaleax deleted the addaleax:onread-internal branch Mar 26, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@addaleax @targos
src: store onread callback in internal field 
This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: nodejs#26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
08d9c4d

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@addaleax @targos
src: store onread callback in internal field 
This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: nodejs#26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
e871a52

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@addaleax @targos
src: store onread callback in internal field 
This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: nodejs#26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c82ee2b

targos added a commit that referenced this pull request Mar 27, 2019

@addaleax @targos
src: store onread callback in internal field 
This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: #26837
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
13eb1d8

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.