Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: reduce internal usage of public util for manifest.js #26833

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@targos targos

@BridgeAR BridgeAR

@shisama shisama

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready
Projects
None yet
Milestone
No milestone
7 participants
@Naturalclar @ZYSzys @jasnell @lpinca @targos @BridgeAR @shisama
@Naturalclar
Copy link
Contributor

Naturalclar commented Mar 21, 2019

This PR is part of issue #26546

Replaced usage of public require('util')

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Naturalclar Naturalclar referenced this pull request Mar 21, 2019

Open

lib: reduce internal usage of public require('util') #26546

@ZYSzys

ZYSzys approved these changes Mar 21, 2019
View changes

@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member

ZYSzys commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21718/
@targos

targos approved these changes Mar 21, 2019
View changes

@shisama

shisama approved these changes Mar 21, 2019
View changes

@jasnell

jasnell approved these changes Mar 21, 2019
View changes

@ZYSzys ZYSzys added the author ready label Mar 21, 2019

@BridgeAR

BridgeAR approved these changes Mar 22, 2019
View changes

@lpinca

lpinca approved these changes Mar 22, 2019
View changes

@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member

ZYSzys commented Mar 23, 2019

Landed in afdadbc 🎉

@ZYSzys ZYSzys closed this Mar 23, 2019

ZYSzys added a commit that referenced this pull request Mar 23, 2019

@Naturalclar @ZYSzys
policy: reduce internal usage of public util for manifest.js 
PR-URL: #26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Loading status checks…
afdadbc

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@Naturalclar @targos
policy: reduce internal usage of public util for manifest.js 
PR-URL: nodejs#26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6347e4a

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@Naturalclar @targos
policy: reduce internal usage of public util for manifest.js 
PR-URL: nodejs#26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
900fb2f

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@Naturalclar @targos
policy: reduce internal usage of public util for manifest.js 
PR-URL: nodejs#26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
7f116c3

targos added a commit that referenced this pull request Mar 27, 2019

@Naturalclar @targos
policy: reduce internal usage of public util for manifest.js 
PR-URL: #26833
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c127bec

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.