Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: stricter `from()` input validation #26825

Closed
wants to merge 2 commits into from

Conversation

@BridgeAR
Copy link
Member

commented Mar 20, 2019

So far we did not throw an error for all types of invalid input.
Functions do not return a buffer anymore and number and symbol
validation is also improved.

@cjihrig you opened your PR (#26743) to address the function part first. Please feel free to reopen your PR and I'll either rebase on top of your or just close mine if you would like to pull in my changes.

@ChALkeR you also said that you have a PR almost ready, I am happy to close this one.

@nodejs/tsc is this semver-major because of the function validation (if a function is passed in, it seems like a bug, so I am not sure)? The message part is AFAIK not semver-major.

Fixes: #26741

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@BridgeAR
buffer: stricter `from()` input validation 
So far we did not throw an error for all types of invalid input.
Functions do not return a buffer anymore and `number` and `symbol`
validation is also improved.
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
e6bd94a
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 20, 2019

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2992/pipeline

@nodejs-github-bot nodejs-github-bot added the buffer label Mar 20, 2019

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 24, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21845/
@mcollina
mcollina approved these changes Mar 24, 2019
View changes
Copy link
Member

left a comment

LGTM
@BridgeAR
fixup! buffer: stricter `from()` input validation 
Recent code changes require this change.
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
10c6fde
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 24, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21846/

@BridgeAR BridgeAR added the author ready label Mar 24, 2019

@Fishrock123

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 25, 2019

Yeah I guess the function thing is technically semver-major but it is quite certainly an error and trap.

@BridgeAR BridgeAR requested review from jasnell, ChALkeR, cjihrig and bnoordhuis Mar 27, 2019

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 27, 2019

@nodejs/buffer PTAL
@ZYSzys
ZYSzys reviewed Mar 28, 2019
View changes
lib/buffer.js Show resolved Hide resolved

@BridgeAR BridgeAR requested a review from Trott Mar 28, 2019

@ZYSzys
ZYSzys approved these changes Mar 29, 2019
View changes
@targos
targos approved these changes Mar 29, 2019
View changes
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 29, 2019

@targos @mcollina are you fine landing this as semver-patch?

CITGM master https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1782/
CITGM this PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1783/
@mcollina

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 29, 2019

I’m fine as patch.
@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 30, 2019

Landed in 75eaf25

@targos targos closed this Mar 30, 2019

targos added a commit that referenced this pull request Mar 30, 2019
@BridgeAR @targos
buffer: use stricter `from()` input validation 
So far we did not throw an error for all types of invalid input.
Functions do not return a buffer anymore and `number` and `symbol`
validation is also improved.

PR-URL: #26825
Fixes: #26741
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
75eaf25
BethGriggs added a commit that referenced this pull request Apr 5, 2019
@BridgeAR @BethGriggs
buffer: use stricter `from()` input validation 
So far we did not throw an error for all types of invalid input.
Functions do not return a buffer anymore and `number` and `symbol`
validation is also improved.

PR-URL: #26825
Fixes: #26741
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
1ef2443
BethGriggs added a commit that referenced this pull request Apr 9, 2019
@BridgeAR @BethGriggs
buffer: use stricter `from()` input validation 
So far we did not throw an error for all types of invalid input.
Functions do not return a buffer anymore and `number` and `symbol`
validation is also improved.

PR-URL: #26825
Fixes: #26741
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
82c328a
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@targos targos

@ZYSzys ZYSzys

@bnoordhuis bnoordhuis

@ChALkeR ChALkeR

@jasnell jasnell

@Trott Trott

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready buffer
Projects
None yet
Milestone
No milestone
6 participants
@BridgeAR @nodejs-github-bot @Fishrock123 @mcollina @targos @ZYSzys
You can’t perform that action at this time.