Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_events: remove usage of require('util') #26822

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@BridgeAR BridgeAR

@shisama shisama

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
author ready trace_events
Projects
None yet
Milestone
No milestone
6 participants
@dnlup @shisama @ZYSzys @jasnell @BridgeAR @nodejs-github-bot
@dnlup
Copy link
Contributor

dnlup commented Mar 20, 2019

Use require('internal/util/inspect').format instead of
require('util').format.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@dnlup
trace_events: remove usage of require('util') 
Use `require('internal/util/inspect').format` instead of 
`require('util').format`.

Refs: #26546
Loading status checks…
32834db

@nodejs-github-bot nodejs-github-bot added the trace_events label Mar 20, 2019

@joyeecheung joyeecheung referenced this pull request Mar 20, 2019

Open

lib: reduce internal usage of public require('util') #26546

@shisama

shisama approved these changes Mar 21, 2019
View changes

@shisama

This comment has been minimized.

Sign in to view
Copy link
Contributor

shisama commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21730/
@jasnell

jasnell approved these changes Mar 21, 2019
View changes

@BridgeAR

BridgeAR approved these changes Mar 22, 2019
View changes

@BridgeAR BridgeAR added the author ready label Mar 22, 2019

@ZYSzys

ZYSzys approved these changes Mar 24, 2019
View changes

@ZYSzys

This comment has been minimized.

Sign in to view
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in a894514 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019

ZYSzys added a commit that referenced this pull request Mar 24, 2019

@dnlup @ZYSzys
trace_events: remove usage of require('util') 
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Loading status checks…
a894514

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@dnlup @targos
trace_events: remove usage of require('util') 
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
1e2cbca

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@dnlup @targos
trace_events: remove usage of require('util') 
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
1517d06

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@dnlup @targos
trace_events: remove usage of require('util') 
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: nodejs#26546

PR-URL: nodejs#26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
1d22251

targos added a commit that referenced this pull request Mar 27, 2019

@dnlup @targos
trace_events: remove usage of require('util') 
Use `require('internal/util/inspect').format` instead of
`require('util').format`.

Refs: #26546

PR-URL: #26822
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
0f9a779

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.