Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: apply clang-tidy readability-delete-null-pointer #26813

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Reviewers

@refack refack

@bnoordhuis bnoordhuis

@addaleax addaleax

@richardlau richardlau

Assignees
No one assigned
Labels
C++ author ready
Projects
None yet
Milestone
No milestone
6 participants
@gengjiawen @refack @bnoordhuis @addaleax @richardlau @nodejs-github-bot
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 20, 2019 •
edited by refack

see: https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null and https://clang.llvm.org/extra/clang-tidy/checks/readability-delete-null-pointer.html.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the C++ label Mar 20, 2019

@refack

refack approved these changes Mar 20, 2019
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Mar 20, 2019 •
edited

@gengjiawen I think you should add a .clang-tidy file to the /src/ directory (like V8's) and add each rule you fix...

CI: https://ci.nodejs.org/job/node-test-pull-request/21696/
Resume: https://ci.nodejs.org/job/node-test-pull-request/21704/
@gengjiawen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gengjiawen commented Mar 20, 2019

yeap, but I am still working on a way to ensure the rules.
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Mar 20, 2019

Very preliminary https://ci.nodejs.org/job/node-clang-tidy/1/console
@bnoordhuis

bnoordhuis approved these changes Mar 20, 2019
View changes

@refack refack added the author ready label Mar 20, 2019

@richardlau

richardlau approved these changes Mar 20, 2019
View changes

@gengjiawen gengjiawen referenced this pull request Mar 21, 2019

Open

[WIP]tools: add clang-tidy rule in src #26840

1 of 2 tasks complete
@addaleax

addaleax approved these changes Mar 21, 2019
View changes

@joyeecheung joyeecheung referenced this pull request Mar 22, 2019

Open

CI failures: 20190322 #21

@gengjiawen @refack
src: apply clang-tidy readability-delete-null-pointer 
PR-URL: #26813
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Loading status checks…
c757cb1

@refack refack force-pushed the gengjiawen:readability-delete-null-pointer branch from 6838311 to c757cb1 Mar 22, 2019

@refack refack merged commit c757cb1 into nodejs:master Mar 22, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy readability-delete-null-pointer 
PR-URL: nodejs#26813
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
86df530

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy readability-delete-null-pointer 
PR-URL: nodejs#26813
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
7e32c0b

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy readability-delete-null-pointer 
PR-URL: nodejs#26813
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e81b01e

targos added a commit that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy readability-delete-null-pointer 
PR-URL: #26813
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
6de2437

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.