Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: apply clang-tidy performance-faster-string-find #26812

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Reviewers

@refack refack

@jasnell jasnell

@richardlau richardlau

Assignees
No one assigned
Labels
C++ inspector report
Projects
None yet
Milestone
No milestone
6 participants
@gengjiawen @refack @BridgeAR @jasnell @richardlau @nodejs-github-bot
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 20, 2019 •
edited by refack

rule def: https://clang.llvm.org/extra/clang-tidy/checks/performance-faster-string-find.html.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added C++ inspector report labels Mar 20, 2019

@gengjiawen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gengjiawen commented Mar 21, 2019 •
edited

@addaleax @refack Can you review this and #26815? thanks.
@richardlau

richardlau approved these changes Mar 21, 2019
View changes

@refack

refack approved these changes Mar 21, 2019
View changes

@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Mar 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21729/

@refack refack added the author ready label Mar 21, 2019

@jasnell

jasnell approved these changes Mar 21, 2019
View changes

@gengjiawen gengjiawen referenced this pull request Mar 21, 2019

Open

[WIP]tools: add clang-tidy rule in src #26840

1 of 2 tasks complete

@joyeecheung joyeecheung referenced this pull request Mar 22, 2019

Open

CI failures: 20190322 #21

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 22, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21803/
@gengjiawen @refack
src: apply clang-tidy performance-faster-string-find 
PR-URL: #26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
86e0296

@refack refack force-pushed the gengjiawen:clang-tidy-performance-faster-string-find branch from acf42c0 to 86e0296 Mar 22, 2019

@refack refack removed the author ready label Mar 22, 2019

@refack refack merged commit 86e0296 into nodejs:master Mar 22, 2019

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy performance-faster-string-find 
PR-URL: nodejs#26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
accb14b

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy performance-faster-string-find 
PR-URL: nodejs#26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
3f013b7

targos added a commit to targos/node that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy performance-faster-string-find 
PR-URL: nodejs#26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
579d043

targos added a commit that referenced this pull request Mar 27, 2019

@gengjiawen @targos
src: apply clang-tidy performance-faster-string-find 
PR-URL: #26812
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
de50346

@targos targos referenced this pull request Mar 27, 2019

Merged

v11.13.0 release proposal #26949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.