Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-8677: use PY_SSIZE_T_CLEAN in sqlite #12434

Merged
merged 2 commits into from Mar 19, 2019
Merged

bpo-8677: use PY_SSIZE_T_CLEAN in sqlite #12434

merged 2 commits into from Mar 19, 2019

Conversation

methane
Copy link
Member

@methane methane commented Mar 19, 2019 •
edited by bedevere-bot

Modules/_sqlite/cursor.c uses "y#" format.

https://bugs.python.org/issue8677

methane added 2 commits Mar 19, 2019
@methane
sqlite: use PY_SSIZE_T_CLEAN
8313973 
Modules/_sqlite/cursor.c uses "y#" format.
But it didn't declare PY_SSIZE_T_CLEAN.
@methane
define PY_SSIZE_T_CLEAN before all Python.h includes
6b8b8bf
pablogsal
pablogsal approved these changes Mar 19, 2019
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

I would also inspect in case there are opportunities to use Py_ssize_t instead of int in the modules.

@methane methane merged commit 29198ea into python:master Mar 19, 2019
@methane methane deleted the sqlite-ssizet branch Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@methane @pablogsal @the-knights-who-say-ni @bedevere-bot