Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd task for packaging release #6
+48
−14
Conversation
code-asher
requested a review
from
kylecarbs
Mar 5, 2019
code-asher
force-pushed the
feature/release-script
branch
2 times, most recently
from
2b35d4f
to
5478f3a
Mar 5, 2019
kylecarbs
reviewed
Mar 5, 2019
build/tasks.ts Outdated
code-asher
force-pushed the
feature/release-script
branch
2 times, most recently
from
b9894d3
to
69133cb
Mar 6, 2019
This comment has been minimized.
This comment has been minimized.
|
Optimally we'd fix the |
code-asher
added some commits
Mar 5, 2019
code-asher
force-pushed the
feature/release-script
branch
from
561e786
to
85c192e
Mar 6, 2019
Multishifties
reviewed
Mar 6, 2019
| runner.cwd = releasePath; | ||
| await os.platform() === "linux" | ||
| ? runner.execute("tar", ["-cvzf", `${archiveName}.tar.gz`, `${archiveName}`]) | ||
| : runner.execute("zip", ["-r", `${archiveName}.zip`, `${archiveName}`]); |
This comment has been minimized.
This comment has been minimized.
Multishifties
Mar 6, 2019
•
Contributor
For our use case, is tar preferable to zip? And if so, is there any way for us to set a conditional based on whether or not said commands are installed rather than OS platform? Or is it inconsequential and/or not worth the time?
This comment has been minimized.
This comment has been minimized.
code-asher
Mar 6, 2019
•
Author
Collaborator
The goal is to provide tarballs for Linux builds and zips for Mac & Windows builds. This runs in the CI and is what will be available for download on the releases page.
code-asher
merged commit 994531d
into
master
Mar 7, 2019
code-asher
deleted the
feature/release-script
branch
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
code-asher commentedMar 5, 2019
No description provided.