Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove legacy e2e tests job #28645

Closed
wants to merge 5 commits into
base: master
from
+351 −552

Conversation

Reviewers

@IgorMinar IgorMinar

Assignees

@alexeagle alexeagle

@IgorMinar IgorMinar

Labels
PR action: merge PR action: merge-assistance PR target: master-only cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
5 participants
@devversion @IgorMinar @mhevery @googlebot @alexeagle
@devversion
Copy link
Member

devversion commented Feb 11, 2019 •
edited

See individual commits for changes

Though most lack of commit descriptions as there is not too much to write about..

@devversion devversion requested a review from IgorMinar as a code owner Feb 11, 2019

@googlebot googlebot added the cla: yes label Feb 11, 2019

@devversion devversion force-pushed the devversion:build/convert-largetable-benchmarks-to-bazel branch 2 times, most recently from 5cd0e47 to 755630e Feb 11, 2019

@devversion devversion added comp: build & ci PR target: master & patch labels Feb 11, 2019

@ngbot ngbot bot added this to the needsTriage milestone Feb 11, 2019

@devversion devversion added the PR action: review label Feb 11, 2019

@devversion devversion assigned alexeagle and IgorMinar Feb 11, 2019

@devversion devversion requested a review from angular/fw-dev-infra as a code owner Feb 11, 2019

@devversion devversion referenced this pull request Feb 11, 2019

Closed

build: convert largeform benchmarks to bazel #28649

@devversion devversion changed the title build: convert largetable benchmark tests to bazel build: remove legacy e2e tests job Feb 11, 2019

@devversion devversion force-pushed the devversion:build/convert-largetable-benchmarks-to-bazel branch 3 times, most recently from 1cbcd06 to 5e8f802 Feb 11, 2019

devversion added some commits Feb 11, 2019

@devversion
build: serve largetable benchmark tests with bazel
Loading status checks…
e39aaf9
@devversion
build: run largetable benchmark tests with bazel
Loading status checks…
dd1cc93
@devversion
build: convert largeform benchmarks to bazel 
Switches the `largeform` benchmarks to Bazel.
This is the last remaining e2e test within `modules/`.
Loading status checks…
7ef9419
@devversion
build: remove legacy e2e tests job 
Now that all e2e integration tests within `modules/` have been
migrated to Bazel, we can remove the legacy e2e tests job.
Loading status checks…
3388e0d
@devversion
build: update instructions to run benchmark tests 
* Updates the instructions on how to run the benchmark tests.
* Removes the unused `favicon.ico` file and the corresponding Bazel filegroup
Loading status checks…
f688f5c

@devversion devversion force-pushed the devversion:build/convert-largetable-benchmarks-to-bazel branch from 5e8f802 to 3388e0d Feb 12, 2019

@IgorMinar

IgorMinar approved these changes Feb 13, 2019
View changes

Copy link
Member

IgorMinar left a comment

thanks!
@IgorMinar

This comment has been minimized.

Sign in to view
Copy link
Member

IgorMinar commented Feb 13, 2019

http://test/OCL:233686636:BASE:233686675:1550036012078:3eae8642

@IgorMinar IgorMinar added PR action: merge PR action: merge-assistance and removed PR action: review labels Feb 13, 2019

@IgorMinar

This comment has been minimized.

Sign in to view
Copy link
Member

IgorMinar commented Feb 13, 2019

merge-assistance: the bot seems confused. this pr should be green.
@mhevery

This comment has been minimized.

Sign in to view
Copy link
Member

mhevery commented Feb 13, 2019

This PR does not apply cleanly to patch brach. Pleas break this up into a master PR and batch PR and ping for re-merge.

@devversion devversion referenced this pull request Feb 13, 2019

Closed

build: remove legacy e2e job patch version [patch version] #28697

@devversion

This comment has been minimized.

Sign in to view
Copy link
Member Author

devversion commented Feb 13, 2019

Here is the patch version of this PR: #28697

@devversion devversion added PR target: master-only and removed PR target: master & patch labels Feb 13, 2019

@mhevery mhevery closed this in 1a326d5 Feb 13, 2019

mhevery added a commit that referenced this pull request Feb 13, 2019

@devversion @mhevery
build: run largetable benchmark tests with bazel (#28645) 
PR Close #28645
1368513

mhevery added a commit that referenced this pull request Feb 13, 2019

@devversion @mhevery
build: convert largeform benchmarks to bazel (#28645) 
Switches the `largeform` benchmarks to Bazel.
This is the last remaining e2e test within `modules/`.

PR Close #28645
0a4811c

mhevery added a commit that referenced this pull request Feb 13, 2019

@devversion @mhevery
build: update instructions to run benchmark tests (#28645) 
* Updates the instructions on how to run the benchmark tests.
* Removes the unused `favicon.ico` file and the corresponding Bazel filegroup

PR Close #28645
fb194d5

mhevery added a commit that referenced this pull request Feb 13, 2019

@devversion @mhevery
build: remove legacy e2e tests job (#28645) 
Now that all e2e integration tests within `modules/` have been
migrated to Bazel, we can remove the legacy e2e tests job.

PR Close #28645
Loading status checks…
dba2a40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.