Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VisualStudio.gitignore file #2975

Merged
merged 2 commits into from Mar 11, 2019
Merged

Update VisualStudio.gitignore file #2975

merged 2 commits into from Mar 11, 2019

Conversation

@JFMG
Copy link
Contributor

@JFMG JFMG commented Feb 25, 2019

Reasons for making this change:

Added
mono_crash.* // Some executed unit tests in a .NET Core project may lead to a mono crash which then generates this file

Changed:
// Just to be conform with the other folder name conventions
x64/ => [Xx]64/
x86/ => [Xx]86/

// Visual Studio For Mac sometimes creates multiple bin and obj folders with increasing numbers, e.g. "bin 2/" (bin n/ where n = i + 1 and i starts from 0)
[Bb]in/ => [Bb]in*/
[Oo]bj/ => [Oo]bj*/
[Ll]og/ => [Ll]og*/

Links to documentation supporting these rule changes:

🤷🏻‍♂️

José Fabio Martinez Gonzalez
Added
mono_crash.* // Some executed unit tests in a .NET Core project may lead to a mono crash which then generates this file

Changed:
// Just to be conform with the other folder name conventions
x64/ => [Xx]64/
x86/ => [Xx]86/

// Visual Studio For Mac sometimes creates multiple bin and obj folders with increasing numbers, e.g. "bin 2/" (bin n/ where n = i + 1 and i starts from 0)
[Bb]in/ => [Bb]in*/
[Oo]bj/ => [Oo]bj*/
[Ll]og/ => [Ll]og*/
@shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 8, 2019

@JFMG some initial feedback:

mono_crash.*

Good catch!

// Just to be conform with the other folder name conventions
x64/ => [Xx]64/
x86/ => [Xx]86/

Any idea where this came from? I'm tentatively 👍, just wondering if there's extra context because x in these platform names has been a thing for a loooooong time.

// Visual Studio For Mac sometimes creates multiple bin and obj folders with increasing numbers, e.g. "bin 2/" (bin n/ where n = i + 1 and i starts from 0)

This feels like an uncommon scenario where the tooling might not be able to write to its preferred paths. I'm 👎 on this without more information or context for this behaviour.

@JFMG
Copy link
Contributor Author

@JFMG JFMG commented Mar 9, 2019

@shiftkey

Good catch!

Thanks :-)

Any idea where this came from?

I wish I'd know 😅

This feels like an uncommon scenario where the tooling might not be able to write to its preferred paths.

Yep, this might be true. I've seen it a few times when Visual Studio for Mac and for Windows were in use. My guess is that in some cases the obj and bin folders get locked and therefore VS is not able to write into these folders. I didn't find any further information about this issue. It might be a bug in the tooling as you said.

Reverted `x64/`, `x86`, `[Bb]in/`, `[Oo]bj/` and `[Ll]og/`.
@shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 11, 2019

@JFMG thanks!

@shiftkey shiftkey merged commit b960d3c into github:master Mar 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Kiku-Reise added a commit to Kiku-Reise/gitignore that referenced this pull request Apr 6, 2019
* Update VisualStudio.gitignore file
Ortega-Dan added a commit to Ortega-Dan/gitignore that referenced this pull request Jun 26, 2019
* Update VisualStudio.gitignore file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants