Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport Poetry depenedency manager #1871
Comments
This comment has been minimized.
This comment has been minimized.
|
No specific plans at the moment, but if people begin to vote for this issue with a |
brettcannon
added
the
needs upstream fix
label
Jun 13, 2018
This comment has been minimized.
This comment has been minimized.
|
We are going to wait until poetry hits version 1.0 before making a decision about this. People should continue to leave a |
brettcannon
added
needs PR
and removed
needs decision
needs upstream fix
labels
Oct 29, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
kevinpostal
commented
Jan 16, 2019
|
+1 Add support, please |
This comment has been minimized.
This comment has been minimized.
kevinpostal
commented
Jan 16, 2019
|
One workaround is to use virtualenvs in project root. Then vscode picks it up. |
This comment has been minimized.
This comment has been minimized.
qubitron
commented
Jan 30, 2019
|
We are looking at implementing this, so I want to clarify the desired behavior here: if Poetry is detected in the current environment, prompt user if they want to install packages (pylint, rope, etc) using poetry. Is that correct? Please let us know if there's additional behavior desired here. |
This comment has been minimized.
This comment has been minimized.
leos
commented
Jan 31, 2019
|
Any installations should happen via poetry. It would also be great if VS Code could autodetect the poetry virtualenv and use it. |
This comment has been minimized.
This comment has been minimized.
lig
commented
Jan 31, 2019
|
@qubitron personally, I found |
This comment has been minimized.
This comment has been minimized.
DonJayamanne
commented
Jan 31, 2019
Activating poetry environments do not work (at least not yet). If things don't work in the tool itself, we're not going to try to add workarounds or implement solutions. What can be done however is just add support for using I.e. when user needs to install a formatter, we'll (optionally) make use of |
This comment has been minimized.
This comment has been minimized.
|
@lig since we do not manage environment creation that will be out of scoped for this work. |
This comment has been minimized.
This comment has been minimized.
abhishekvm
commented
Feb 17, 2019
Till the time support for poetry gets added, I was thinking if there is any hacky way we can get through this. vscode installs any packages with following command: Is there any way in vscode where we can map |
This comment has been minimized.
This comment has been minimized.
|
@abhishekvm nope, we don't provide that kind of functionality. You can always do the install manually while people wait for this feature since as you noticed we aren't doing anything too magical. |
This comment has been minimized.
This comment has been minimized.
DonJayamanne
commented
Feb 27, 2019
•
|
DonJayamanne
self-assigned this
Mar 5, 2019
DonJayamanne
added this to the 2019, week 9 - Feb Sprint 5 milestone
Mar 5, 2019
DonJayamanne
referenced this issue
Mar 6, 2019
Merged
Add support for poetry dependency manager #4654
DonJayamanne
assigned
ericsnowcurrently
Mar 11, 2019
This comment was marked as off-topic.
This comment was marked as off-topic.
dclong
commented
Mar 12, 2019
|
It's great if the pybuilder dependency management is also supported. |
dclong
referenced this issue
Mar 12, 2019
Open
Feature Request: Support pybuilder depenedency manager #4720
This comment was marked as resolved.
This comment was marked as resolved.
|
@dclong please open a separate issue. |
DonJayamanne
removed this from the 2019, week 9 - Feb Sprint 5 milestone
Mar 13, 2019
DonJayamanne
added this to the 2019, week 11 - March Sprint 6 milestone
Mar 13, 2019
This comment has been minimized.
This comment has been minimized.
|
I was able to verify that poetry is used to install modules:
This caused the popup for installing flake8. Then poetry was used to install flake8. |
mackeyja92 commentedJun 5, 2018
•
edited by DonJayamanne
Currently it looks like Pipenv is supported but not poetry. Is there plans to support this dependency manager as well?
Note:
Activating poetry environments do not work (at least not yet).
sdispater/poetry#198
sdispater/poetry#571