/vscode-python forked from DonJayamanne/pythonVSCode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'LogPoints' in debugger #1306

Closed
DonJayamanne opened this Issue Apr 5, 2018 · 4 comments

Comments

Assignees

@DonJayamanne DonJayamanne

Labels
feature-debugging type-enhancement
Projects
None yet
Milestone
  May 2018
3 participants
@DonJayamanne @qubitron @brettcannon
@DonJayamanne

DonJayamanne commented Apr 5, 2018 •
edited

PTVS has this today, they call it Trace Points (hence functionality should be available in the new version of PTVSD).

Requires upstream changes as well #1306

@DonJayamanne DonJayamanne added type-enhancement needs PR feature-debugging labels Apr 5, 2018

@qubitron

This comment has been minimized.

Sign in to view

qubitron commented Apr 5, 2018

FYI this is currently planned for the March release for VS Code, Microsoft/vscode#45128, but it might be at preview quality.
@DonJayamanne

This comment has been minimized.

Sign in to view

DonJayamanne commented Apr 6, 2018

but it might be at preview quality.

Is this based on the issues/feedback on VS Code github repo?
@qubitron

This comment has been minimized.

Sign in to view

qubitron commented Apr 6, 2018

Per Kenneth's last comment in the upstream issue, he had some concerns with readiness.

@qubitron qubitron added this to the May 2018 milestone Apr 12, 2018

@DonJayamanne DonJayamanne self-assigned this Apr 16, 2018

@DonJayamanne

This comment has been minimized.

Sign in to view

DonJayamanne commented Apr 16, 2018

@qubitron
I've managed to get this working in PTVSD (Microsoft/ptvsd#350).
I think we can land this feature as well.

@DonJayamanne DonJayamanne referenced this issue Apr 17, 2018

Merged

Add support for log points #1406

4 of 4 tasks complete

@DonJayamanne DonJayamanne closed this in #1406 Apr 17, 2018

DonJayamanne added a commit that referenced this issue Apr 17, 2018

@DonJayamanne
Add support for log points 
Fixes #1306
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41ec24a

@brettcannon brettcannon added the validate fix label Apr 23, 2018

@brettcannon brettcannon removed needs PR validate fix labels Apr 30, 2018

@DonJayamanne DonJayamanne referenced this issue May 8, 2018

Closed

Add unit tests for log points #1426

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.