New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update and unify gitignore #28316

Closed

pkozlowski-opensource wants to merge 1 commit into angular:master from pkozlowski-opensource:update_gitignore

Member

pkozlowski-opensource commented Jan 23, 2019 •

edited

After pulling latest master today I've started to see bazel-out popping as an untracked. This is due to the fact that /bazel-out/ would much folders only but it is a symlink (thnx @gkalpak for figuring this out).

I've also removed bower_components as bower is gone.

pkozlowski-opensource requested a review from angular/fw-dev-infra as a code owner Jan 23, 2019

googlebot added the cla: yes label Jan 23, 2019

pkozlowski-opensource added comp: build & ci PR action: review PR target: master-only PR action: time-zone labels Jan 23, 2019

ngbot bot added this to the needsTriage milestone Jan 23, 2019

Member

gkalpak commented Jan 23, 2019

For reference, bazel-out was changed in #27781.

gkalpak reviewed Jan 23, 2019

View changes

.gitignore Outdated

  
        /integration/bazel/bazel-*

        dist

        bazel-out

        integration/bazel/bazel-*

gkalpak Jan 23, 2019 •

edited

Member

Removing leading and trailing slashes changes the semantics. (More info)
I am not sure what the "right" behavior is (since I don't know what bazel-out is or where it might pop up); just bringing it up.

pkozlowski-opensource Jan 23, 2019

Author Member

Updated to preserve leading /

pkozlowski-opensource force-pushed the pkozlowski-opensource:update_gitignore branch 2 times, most recently from `e6723c1` to `e23fac5` Jan 23, 2019


      build: update and unify gitignore

e23fac5

gkalpak approved these changes Jan 23, 2019

View changes

ocombe approved these changes Jan 23, 2019

View changes

Member

filipesilva commented Jan 23, 2019

Related to

angular/.bazelrc

Lines 29 to 36 in 8f1198f

    
           # NB: bazel-out should be excluded from the editor configuration. 
        
           # The checked-in /.vscode/settings.json does this for VSCode. 
        
           # Other editors may require manual config to ignore this directory. 
        
           # In the past, we say a problem where VSCode traversed a massive tree, opening file handles and 
        
           # eventually a surprising failure with auto-discovery of the C++ toolchain in 
        
           # MacOS High Sierra. 
        
           # See https://github.com/bazelbuild/bazel/issues/4603 
        
           build --symlink_prefix=dist/

alexeagle approved these changes Jan 23, 2019

View changes

Contributor

alexeagle left a comment

Thanks!

pkozlowski-opensource added PR action: merge and removed PR action: review labels Jan 23, 2019

alxhub closed this in `1fd6735` Jan 23, 2019

vetom added a commit to vetom/angular that referenced this pull request Jan 31, 2019


      build: update and unify gitignore (angular#28316)

PR Close angular#28316

ab95aab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.