Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34605: childs => children #9102

Merged
merged 1 commit into from Sep 7, 2018
Merged

bpo-34605: childs => children #9102

merged 1 commit into from Sep 7, 2018

Conversation

Reviewers

@ericvsmith ericvsmith

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@vstinner @ericvsmith @perfide @the-knights-who-say-ni @bedevere-bot
@vstinner
Copy link
Member

@vstinner vstinner commented Sep 7, 2018 •
edited by bedevere-bot
Loading

https://bugs.python.org/issue34605
@vstinner
bpo-34605: childs => children
795dd27
@vstinner vstinner mentioned this pull request Sep 7, 2018
Merged
@vstinner vstinner requested a review from ericvsmith Sep 7, 2018
@ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Sep 7, 2018

Looks good to me!

Loading

@ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Sep 7, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

Loading

@vstinner
Copy link
Member Author

@vstinner vstinner commented Sep 7, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

works for me :-)

Loading

@vstinner vstinner merged commit 7e610bc into python:master Sep 7, 2018
9 checks passed
Loading
@vstinner vstinner deleted the pliant branch Sep 7, 2018
lisroach added a commit to lisroach/cpython that referenced this issue Sep 12, 2018
@vstinner @lisroach
bpo-34605: childs => children (pythonGH-9102)
97aef08
@perfide
Copy link

@perfide perfide commented Sep 13, 2018

Forgot: I don't know what they're trying to say with pliant, so I suggest leaving it alone.

"pliant children" makes no sense.
It made sense as "pliant slave", a bad joke though.
I think "and its helper functions, like" is easier to understand.

Loading

@python python locked and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.