Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34898: Add mtime argument to gzip.compress #9704

Merged
merged 5 commits into from Nov 7, 2018
Merged

bpo-34898: Add mtime argument to gzip.compress #9704

merged 5 commits into from Nov 7, 2018
+27 −4

Conversation

guoci
Copy link
Contributor

@guoci guoci commented Oct 4, 2018 •
edited

Add mtime argument to gzip.compress for reproducible output.

https://bugs.python.org/issue34898

@guoci guoci force-pushed the gzip_mtime branch 3 times, most recently from 755c7ea to 8cf43cc Compare October 6, 2018 17:48
matrixise
matrixise requested changes Oct 11, 2018
View reviewed changes
Doc/library/gzip.rst Outdated Show resolved Hide resolved
Lib/test/test_gzip.py Outdated Show resolved Hide resolved
matrixise
matrixise requested changes Oct 12, 2018
View reviewed changes
Doc/library/gzip.rst Outdated Show resolved Hide resolved
vadmium
vadmium reviewed Oct 14, 2018
View reviewed changes
Doc/library/gzip.rst Outdated Show resolved Hide resolved
@guoci guoci force-pushed the gzip_mtime branch 3 times, most recently from 0909cbd to 32ced50 Compare October 20, 2018 18:33
@guoci guoci force-pushed the gzip_mtime branch 3 times, most recently from 75185f2 to c86bfd1 Compare October 26, 2018 16:04
@guoci guoci force-pushed the gzip_mtime branch 5 times, most recently from 1dddb9b to 35fd98c Compare November 5, 2018 15:39
serhiy-storchaka
serhiy-storchaka reviewed Nov 5, 2018
View reviewed changes
Doc/library/gzip.rst Outdated Show resolved Hide resolved
Doc/library/gzip.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2018-10-04-17-23-43.bpo-34898.Wo2PoJ.rst Show resolved Hide resolved
Lib/test/test_gzip.py Outdated Show resolved Hide resolved
Lib/test/test_gzip.py Outdated Show resolved Hide resolved
@serhiy-storchaka
Copy link
Member

Would be nice to explain why this parameter is needed.

@guoci
Copy link
Contributor Author

guoci commented Nov 5, 2018 •
edited

Would be nice to explain why this parameter is needed.

Without setting mtime, time.time() will be used as the timestamp which will end up in the compressed data and each invocation of the compress function will vary over time.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Nov 7, 2018
@serhiy-storchaka serhiy-storchaka merged commit 0e7497c into python:master Nov 7, 2018
@dhimmel dhimmel mentioned this pull request Aug 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmium vadmium vadmium left review comments

@tirkarthi tirkarthi tirkarthi left review comments

@matrixise matrixise matrixise requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@guoci @serhiy-storchaka @matrixise @vadmium @tirkarthi @the-knights-who-say-ni @bedevere-bot