Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete comment about latin-1 in normalize_encoding #8739

Merged
merged 1 commit into from Sep 11, 2018

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Aug 11, 2018

This docstring has drifted since python2:

encoding = encoding.encode('latin-1')

@eamanu
Copy link
Contributor

eamanu commented Aug 12, 2018

Hello @asottile

I don't know if is necessary but the bot say that you have to add a new entry on Misc/NEWS. But for me the change is Ok

eamanu
eamanu approved these changes Aug 12, 2018
@asottile
Copy link
Contributor Author

asottile commented Aug 12, 2018

@eamanu yeah usually for trivial changes like this a core dev will sweep by and add [skip issue] and [skip news] tags (for instance: #7366)

@gpshead gpshead added docs Documentation in the Doc dir skip news skip issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants