Skip to content

Commits on Mar 28, 2022

  1. Allow up to 100 CI checks for CI status command

    I'm working on a project that has a complex CI setup, and reaches more
    than 30. Sometimes `hub ci-status` would report success when it was
    still pending, which was very annoying.
    
    per_page=100 is used in many other queries, and is the maximum that is
    allowed without paging.
    rjmunro committed Mar 28, 2022

Commits on Mar 25, 2022

  1. Change default protocol to HTTPS (#2939)

    Explicitly setting `hub.protocol` to `git` or using `HUB_PROTOCOL=git`
    still uses the `git` protocol.
    
    Co-authored-by: Mislav Marohnić <mislav@github.com>
    halostatue and mislav committed Mar 25, 2022
  2. go fmt

    mislav committed Mar 25, 2022
  3. go compat

    mislav committed Mar 25, 2022

Commits on Dec 1, 2020

  1. github: fix unbuffered channel passed to signal.Notify

    The docs at os/signal.Notify warn about this signal delivery loss bug at
    https://golang.org/pkg/os/signal/#Notify, which says:
    
        Package signal will not block sending to c: the caller must ensure
        that c has sufficient buffer space to keep up with the expected signal
        rate. For a channel used for notification of just one signal value,
        a buffer of size 1 is sufficient.
    
    Caught by a static analysis tool from Orijtech, Inc. called "sigchanyzer"
    cuonglm committed Dec 1, 2020

Commits on Apr 3, 2020

Commits on Mar 20, 2020

  1. Fix tests.

    kfcampbell committed Mar 20, 2020

Commits on Mar 5, 2020

  1. Normalize url.Error message for Go 1.14

    Go 1.13: `Post <URL>: <message>`
    Go 1.14: `Post "<URL>": <message>`
    
    Since we have an existing test that includes this error message, make
    sure that `url.Error`s are output without quotes around the URL.
    mislav committed Mar 5, 2020

Commits on Mar 1, 2020

  1. Use git symbolic-ref to read the branch name for HEAD

    This affects reading the current branch as well as reading the default
    branch for a remote. Because we're no longer trying to read the ref
    manually from the filesystem, this approach works with git worktrees.
    mislav committed Mar 1, 2020

Commits on Jan 21, 2020

  1. [version] Support --build-options

    Ensure that all flags are forwarded to `git version`
    
    Fixes #2440
    mislav committed Jan 21, 2020

Commits on Jan 18, 2020

  1. Simplify FormatError

    mislav committed Jan 18, 2020

Commits on Jan 16, 2020

  1. Refuse to follow HTTP 301, 302 redirects for non-GET requests

    Go's `net/http` will intentionally change the HTTP method being used
    after a 301, 302, or 303 redirect for a non-GET request.
    
    When encountering a 301 or 302 response codes, fail any non-GET request
    with an tip that 308 and 307 should be used, respectively.
    mislav committed Jan 16, 2020

Commits on Dec 23, 2019

  1. improve Project SameAs logic

    use strings.EqualFold instead of strings.ToLower with equal
    operation when comparing string ignore case
    johanavril committed Dec 23, 2019

Commits on Dec 11, 2019

Commits on Dec 5, 2019

  1. Avoid ever dumping binary content in HUB_VERBOSE mode for HTTP

    Only ever dump HTTP request/response bodies if they are of the following
    types:
    - `text/*`
    - `application/json` or `*+json`
    
    Allows using `HUB_VERBOSE=1 hub release create -a <file>` to debug
    attaching binary assets.
    mislav committed Dec 5, 2019

Commits on Dec 4, 2019

Commits on Oct 21, 2019

  1. Merge branch 'gist'

    mislav committed Oct 21, 2019

Commits on Oct 18, 2019

  1. code review bits

    jaymzh committed Oct 18, 2019

Commits on Oct 10, 2019

  1. Merge pull request #2286 from github/proxy-from-env

    Support HTTPS_PROXY, NO_PROXY from environment
    mislav committed Oct 10, 2019
Older