Skip to content

docs(bazel): add skydoc generation#23544

Closed
alexeagle wants to merge 3 commits into
angular:masterfrom
alexeagle:skydoc
Closed

docs(bazel): add skydoc generation#23544
alexeagle wants to merge 3 commits into
angular:masterfrom
alexeagle:skydoc

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle commented Apr 25, 2018

Need to figure out where the docs will go after the .zip file.

Also blocked on skydoc doing a better job following load statements.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 25, 2018

You can preview e786531 at https://pr23544-e786531.ngbuilds.io/.

@ngbot
Copy link
Copy Markdown

ngbot Bot commented May 11, 2018

Hi @alexeagle! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@mhevery mhevery added the area: bazel Issues related to the published `@angular/bazel` build rules label Jul 12, 2018
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 6, 2018

You can preview 2334d72 at https://pr23544-2334d72.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 6698ae8 at https://pr23544-6698ae8.ngbuilds.io/.

@alexeagle alexeagle force-pushed the skydoc branch 2 times, most recently from 998d9ff to 903316f Compare August 7, 2018 03:56
@alexeagle alexeagle requested a review from gregmagolan August 7, 2018 03:58
@alexeagle alexeagle added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: blocked labels Aug 7, 2018
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 998d9ff at https://pr23544-998d9ff.ngbuilds.io/.

@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Aug 7, 2018
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 903316f at https://pr23544-903316f.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 147b18f at https://pr23544-147b18f.ngbuilds.io/.

@alexeagle alexeagle force-pushed the skydoc branch 2 times, most recently from 91f3380 to 8f9615e Compare August 7, 2018 19:10
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 8f9615e at https://pr23544-8f9615e.ngbuilds.io/.

@alexeagle alexeagle force-pushed the skydoc branch 2 times, most recently from 6664a6a to 6995e86 Compare August 7, 2018 22:27
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 6664a6a at https://pr23544-6664a6a.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 6995e86 at https://pr23544-6995e86.ngbuilds.io/.

@alexeagle
docs(bazel): add skydoc generation
2c6a919
@alexeagle
ci: enforce formatting of .bzl files
9e67f71 
These are now enforced in google3 so we want to match, so that PRs don't get held up when we sync
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 7, 2018

You can preview 5c78a7d at https://pr23544-5c78a7d.ngbuilds.io/.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 8, 2018
@kara kara closed this in bfdbdc2 Aug 8, 2018
kara pushed a commit that referenced this pull request Aug 8, 2018
@alexeagle @kara
ci: enforce formatting of .bzl files (#23544)
0908245 
These are now enforced in google3 so we want to match, so that PRs don't get held up when we sync

PR Close #23544
kara pushed a commit that referenced this pull request Aug 8, 2018
@alexeagle @kara
style: format .bzl files with buildifier (#23544)
a3f1e2c 
PR Close #23544
alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 18, 2018
@alexeagle
ci: enforce formatting of .bzl files (angular#23544)
af785f9 
These are now enforced in google3 so we want to match, so that PRs don't get held up when we sync

PR Close angular#23544
alexeagle added a commit to alexeagle/angular that referenced this pull request Sep 18, 2018
@alexeagle
docs(bazel): add skydoc generation (angular#23544)
a5e0ae5 
PR Close angular#23544
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mhevery mhevery mhevery approved these changes

@gregmagolan gregmagolan gregmagolan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexeagle @mary-poppins @mhevery @gregmagolan @googlebot