bpo-26901: Fix the Argument Clinic test suite#8879
Merged
vstinner merged 2 commits intopython:masterfrom Sep 3, 2018
vstinner:test_clinic
Merged
bpo-26901: Fix the Argument Clinic test suite#8879vstinner merged 2 commits intopython:masterfrom vstinner:test_clinic
vstinner merged 2 commits intopython:masterfrom
vstinner:test_clinic
Conversation
* Fix Tools/clinic/clinic_test.py: add missing FakeClinic.destination_buffers attribute and pass a file argument to Clinic(). * Rename Tools/clinic/clinic_test.py to Lib/test/test_clinic.py: add temporary Tools/clinic/ to sys.path to import the clinic module. Co-Authored-By: Pablo Galindo <pablogsal@gmail.com>
Member
Author
|
Since test_clinic.py is now a "regular" test, we get regrtest features for free like reference leak hunting, test.bisect, etc. |
Member
berkerpeksag
left a comment
berkerpeksag
left a comment
There was a problem hiding this comment.
Both PRs look good to me. Thanks for making test_clinic useful again, Victor and Pablo.
Lib/test/test_clinic.py
Outdated
| # Copyright 2012-2013 by Larry Hastings. | ||
| # Licensed to the PSF under a contributor agreement. | ||
| # | ||
| """ |
Member
There was a problem hiding this comment.
Nit: IMO converting this to __doc__ doesn't make it any better. I prefer to keep license headers as comments.
Member
Author
There was a problem hiding this comment.
ok, i reverted this change.
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2018
* Fix Tools/clinic/clinic_test.py: add missing FakeClinic.destination_buffers attribute and pass a file argument to Clinic(). * Rename Tools/clinic/clinic_test.py to Lib/test/test_clinic.py: add temporary Tools/clinic/ to sys.path to import the clinic module. Co-Authored-By: Pablo Galindo <pablogsal@gmail.com> (cherry picked from commit 65fc98e) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
GH-9048 is a backport of this pull request to the 3.7 branch. |
vstinner
added a commit
that referenced
this pull request
Sep 3, 2018
* Fix Tools/clinic/clinic_test.py: add missing FakeClinic.destination_buffers attribute and pass a file argument to Clinic(). * Rename Tools/clinic/clinic_test.py to Lib/test/test_clinic.py: add temporary Tools/clinic/ to sys.path to import the clinic module. Co-Authored-By: Pablo Galindo <pablogsal@gmail.com> (cherry picked from commit 65fc98e) Co-authored-by: Victor Stinner <vstinner@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FakeClinic.destination_buffers attribute and pass a file argument
to Clinic().
add temporary Tools/clinic/ to sys.path to import the clinic
module.
Co-Authored-By: Pablo Galindo pablogsal@gmail.com
https://bugs.python.org/issue26901