Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#433 Update pep-0526.txt - Typo #614

Merged
merged 2 commits into from Apr 11, 2018
Merged

#433 Update pep-0526.txt - Typo #614

merged 2 commits into from Apr 11, 2018

Conversation

@toonarmycaptain
Copy link
Contributor

@toonarmycaptain toonarmycaptain commented Apr 10, 2018

Fixed format so that both Yes//No bullet points display consistently with bullet points.
@toonarmycaptain
#433 Update pep-0526.txt - Typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1339573 
Fixed format so that both Yes//No bullet points display consistently with bullet points.
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Apr 10, 2018

Is the extra space in - Yes on purpose? And why the change in bullet point style?
@toonarmycaptain
Update pep-0526.txt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
237ff4c 
Mistaken additional space
@toonarmycaptain
Copy link
Contributor Author

@toonarmycaptain toonarmycaptain commented Apr 11, 2018

No, the extra space was inadvertent (and has been rectified). No reason for changing the bullet style, I just copied the - style from elsewhere in the document, as I wasn't aware of any convention.
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Apr 11, 2018

@toonarmycaptain no convention, just that both are allowed. But if the PEP itself is flipping back and forth then normalizing doesn't hurt.
@brettcannon brettcannon merged commit dd451b5 into python:master Apr 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@toonarmycaptain @brettcannon @the-knights-who-say-ni