Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension doesn't recognize my project as existing on GitHub #1709

Open
jaredpar opened this issue May 29, 2018 · 17 comments
Open

Extension doesn't recognize my project as existing on GitHub #1709

jaredpar opened this issue May 29, 2018 · 17 comments
Labels
Projects

Comments

@jaredpar
Copy link

@jaredpar jaredpar commented May 29, 2018

  • GitHub Extension for Visual Studio version: 2.5.2.2566
  • Visual Studio version: 15.7.1

When I open VsVim in Visual Studio the GitHub extension window puts up the message:

This repository is not on GitHub

This is certainly not true 😄

As an experiment I hit the "Get Started" button and attempted to publish it hoping it would get the extension to reset a bit and find the extension. The publish failed with "there is already a repository with this name" yet it still won't connect it in Visual Studio.

I looked through the extension.log file a bit and there are too many errors for me to track down this particular problem. Or give me a hint as to what is going on.

Extension log file: https://gist.github.com/jaredpar/ee2c7110c5529e9cde6e67b048d5e925

@jaredpar
Copy link
Author

@jaredpar jaredpar commented May 29, 2018

Actually this error does look a bit interesting:

Error logging into '"https://github.com/"' as 'jaredpa'
Octokit.RateLimitExceededException: API rate limit exceeded for user ID 146967.

My username is jaredpar, not jaredpa. Not sure if that's just a log trimming issue though.

@grokys
Copy link
Contributor

@grokys grokys commented May 30, 2018

Hi @jaredpar!

Thanks for getting in touch. This is something that happens occasionally, and we've not got to the bottom of it, so I'm going to do a dump here of all the relevant information for future reference.

SQLite is failing to load the native dll, sqlite3.dll but failing. It should be looking in C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\GitHub\GitHub\x86 but the x86 part of the path is missing from looking in your logs.

This problem has ben reported before in:

#958
#920

And with another extension:

ericsink/SQLitePCL.raw#54

@shana
Copy link
Collaborator

@shana shana commented May 30, 2018

The error message as it stands today doesn't include the fully probed path, so not having x86 in the log is expected.

@jaredpar We haven't been able to reproduce this problem, so hopefully you can help us finally track it down for good. I'm putting together a build with better error messages and a bit more robustness in loading sqlite, if you'd be willing to give it a try?

@jaredpar
Copy link
Author

@jaredpar jaredpar commented May 30, 2018

@meaghanlewis meaghanlewis added this to Medium Priority in BUGS May 31, 2018
@jaredpar
Copy link
Author

@jaredpar jaredpar commented Jun 5, 2018

Any updates here? The extension is essentially unusable in it's current state.

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jun 7, 2018

@jaredpar 👋,

I was wondering you could use procmon with filters for sqlite3.dll and devenv.exe? Hopefully that would show us where it's probing for and failing to find sqlite3.dll.

@jcansdale jcansdale changed the title Extension doesn't recognize my project as existing on GitHub Extension doesn't recognize my project as existing on GitHub (failed to find sqlite3.dll) Jun 7, 2018
@shana
Copy link
Collaborator

@shana shana commented Jun 7, 2018

I'm so sorry, it's been a rather crazy week around here and I dropped the ball on this 😢
I'll get you a build in a couple of hours!

@shana
Copy link
Collaborator

@shana shana commented Jun 7, 2018

@jaredpar Try the v2.5.2.2803 vsix build at https://ci.appveyor.com/project/github-windows/visualstudio/build/2.5.2.2803/artifacts. It should either work or at least provide better error results.

@jaredpar
Copy link
Author

@jaredpar jaredpar commented Jun 8, 2018

@shana no problem on the delay. I tried that build out and it didn't address my problem.

But I did end up finding a way to solve it. The key was adding a remote named "origin". Previously I had two remotes that looked like this:

C:\Users\jaredpar\code\VsVim> git remote -v
jaredpar        https://github.com/jaredpar/VsVim.git (fetch)
jaredpar        https://github.com/jaredpar/VsVim.git (push)
rick    https://github.com/ricksladkey/VsVim.git (fetch)
rick    https://github.com/ricksladkey/VsVim.git (push)

Once I added "origin" that just pointed to the same place as "jaredpar" then the extension started working immediately.

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jun 8, 2018

@jaredpar,

Coincidentally I'm currently working on this part of the code-base. We assume that the GitHub repository associated with the local repository is pointed to by a remote called origin. We don't necessarily want to use the remote from the tracking branch because the user might be collaborating on a pull request originating from another user's repository.

Showing a link to and PRs from ricksladkeys repository probably wouldn't be very useful. Having said that, if there is no origin, it would probably make sense to fall back to using the remote from the tracking branch.

What do you think?

@jaredpar
Copy link
Author

@jaredpar jaredpar commented Jun 9, 2018

@jcansdale

That makes sense to me.

@shana
Copy link
Collaborator

@shana shana commented Jun 11, 2018

@jaredpar Could you upload your log with this new build? I'm still curious to see if the sqlite exceptions have stopped

@jaredpar
Copy link
Author

@jaredpar jaredpar commented Jun 18, 2018

@shana

Could you upload your log with this new build? I'm still curious to see if the sqlite exceptions have stopped

Sure thing. Will try and get that to you tonight. Sorry for the delay. Been out of town for a week with limited email.

@timdhoffmann
Copy link

@timdhoffmann timdhoffmann commented Oct 3, 2018

@jcansdale
I experienced this issue as well and spent quite some time trying to figure out what's going on (had a simple typo in my remote's name). I think it would be nice to have

  • a) a hint at the necessity to precisely name your remote "origin"
  • b) an integrated fallback
@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Oct 12, 2018

@timdhoffmann 👋

I experienced this issue as well and spent quite some time trying to figure out what's going on (had a simple typo in my remote's name).

Sorry about that! I agree the current situation isn't great.

I'm thinking maybe something along the lines of this:
image

I'm terrible at wording this kind of thing, so let me know if you think of anything that would be make it clearer! Clicking the title would navigate the user to an issue with more details about this.

@jcansdale jcansdale changed the title Extension doesn't recognize my project as existing on GitHub (failed to find sqlite3.dll) Extension doesn't recognize my project as existing on GitHub Oct 12, 2018
@jaredpar
Copy link
Author

@jaredpar jaredpar commented Oct 12, 2018

I think that experience would be perfect. The inability to specify the remote to use is a tad bit annoying. But I also realize not having origin defined is probably the 1% case. As long as there is something telling me that's the problem I can move forward.

@timdhoffmann
Copy link

@timdhoffmann timdhoffmann commented Oct 12, 2018

Agree, that would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
BUGS
  
Medium Priority
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.