Link buttons on PR list don't say what button will do #824

Closed
jcansdale opened this Issue Jan 31, 2017 · 5 comments

Comments

Projects

Done in 2.2.0.8

3 participants
Contributor

jcansdale commented Jan 31, 2017 edited

  • GitHub Extension for Visual Studio version: 2.2.0.6
  1. Hover over PR in list
  2. See tooltip with same text as link/button.

image

I expected the tooltip to be a description of what would happen if you click on the link.
Something like: Check out pull request locally View pull request details.

Collaborator

shana commented Feb 1, 2017

Ah, eh, indeed. I think we were using it to display the full PR title in case it got truncated by the limited horizontal spacing. That was before we had a details view, though, so having the tooltip be more explicit about what it does would be more useful here, I agree.

Collaborator

shana commented Feb 1, 2017

I believe we always capitalize Pull Request because it's a Thing(tm), so maybe "View Pull Request details"? Does that look weird, with everything but details capitalized?

jcansdale added the cosmetic label Feb 1, 2017

Contributor

jcansdale commented Feb 1, 2017

No, I think "View Pull Request details", looks okay.

I guess the # links should also say: "View Pull Request on GitHub"?

jcansdale added the usability label Feb 1, 2017

jcansdale self-assigned this Feb 1, 2017

Collaborator

shana commented Feb 1, 2017

I guess the # links should also say: "View Pull Request on GitHub"?

Yup, sounds like a good idea!

grokys added to In Progress in 2.2.0.8 Feb 16, 2017

grokys moved from In Progress to Done in 2.2.0.8 Feb 27, 2017

grokys moved from Done to Testing in 2.2.0.8 Feb 27, 2017

grokys moved from Testing to In Progress in 2.2.0.8 Feb 27, 2017

Contributor

grokys commented Feb 27, 2017

Closed by #827.

grokys closed this Feb 27, 2017

grokys moved from In Progress to Done in 2.2.0.8 Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment