Fix race condition causing crash in Publish form #192

Merged
merged 2 commits into from Jan 12, 2016

Projects

None yet

2 participants

@shana

See #188

Nate Price and others added some commits Jan 12, 2016
Nate Price Stopped crash after publishing new repository
Visual Studio crashed after publishing, but the publishing process
completed before the crash. A call was made to a disposed object after
the view changed, causing the disposal.
ead03f2
@shana shana Fix race condition
The `ListenToCompletionState` subscription was triggering a navigation
request on the `Next` callback. Depending on how fast VS responds, this
can cause the Sync section to be disposed, along with the `UIController`
instance, before the handler returns, which would cause `UIController`
to crash.

Make sure we only navigate away once the `ListenToCompletionState`
observable is completed, and also tweak the way `Dispose` happens in
`UIController` to minimize races.
3cebf10
@Haacked Haacked merged commit e4cf04c into master Jan 12, 2016

3 checks passed

Details GitHub CLA @shana has accepted the GitHub Contributor License Agreement.
Details VisualStudio Build #2648983 succeeded in 87s
Details jenkins/build_log Jenkins Build Log
@Haacked Haacked deleted the fixes/crash-after-publish branch Jan 12, 2016
@Haacked
GitHub member

Nice catch!

@amytruong amytruong referenced this pull request Jan 20, 2016
Closed

QA for Version 1.0.16.3 #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment