Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2FA dialog stays busy when network connection is down #19

Closed
shana opened this issue Jul 29, 2015 · 4 comments · Fixed by #845
Closed

2FA dialog stays busy when network connection is down #19

shana opened this issue Jul 29, 2015 · 4 comments · Fixed by #845
Labels
bug needs investigation

Comments

@shana
Copy link
Collaborator

@shana shana commented Jul 29, 2015

Imported from https://github.com/github/VisualStudioInternal/issues/346

Repro steps:

  1. Login with an account that has 2fa enabled.
  2. Disconnect internet access from your computer.
  3. Enter 2fa code and hit verify.

Expected: 2fa dialog shows an error message.
Actual: The verify button stays disabled and busy. Note, the dialog is still responsive, the operation just never completes.
@shana shana added the bug label Jul 29, 2015
@shana

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

@shana shana commented Jul 29, 2015

Not sure if this one is actually valid any more, it's from April 25. Needs testing.
@JoshDobbin

This comment has been minimized.

Sign in to view
Copy link

@JoshDobbin JoshDobbin commented Jul 12, 2016

I'm also running into the same issue as of the latest version (1.0.18.6).
@brezho

This comment has been minimized.

Sign in to view
Copy link

@brezho brezho commented Aug 24, 2016

Same here with 2.0.14.4
@StanleyGoldman StanleyGoldman mentioned this issue Feb 1, 2017
Closed
@grokys

This comment has been minimized.

Sign in to view
Copy link
Contributor

@grokys grokys commented Feb 6, 2017

I think this is the same issue as #829 - the 2FA dialog doesn't catch any non-2FA exception and just sits there spinning.
@grokys grokys mentioned this issue Feb 6, 2017
Open
3 of 6 tasks complete
grokys added a commit that referenced this issue Feb 9, 2017
@grokys
Handle errors in 2FA flow.
Loading status checks…
2c38d62 
Handle non 2FA-errors in the 2FA flow. When such an error occurs, the
user is taken back to the username/password view and an error message is
shown. Fixes #829. Fixes #19.
@grokys grokys mentioned this issue Feb 9, 2017
Merged
@grokys grokys closed this in #845 Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs investigation
Projects
None yet
Milestone
No milestone
4 participants
@shana @JoshDobbin @brezho @grokys
You can’t perform that action at this time.