/VisualStudio

New issue

GitHub Enterprise Repo Links are always SSL #13

Closed
Jaben opened this Issue Jul 28, 2015 · 5 comments

Projects

None yet

Labels

bug

Milestone

  1.0.12

Assignees

@Haacked Haacked

4 participants

@Jaben @Haacked @shana @fabriciogs
@Jaben
Jaben commented Jul 28, 2015

First of all, thanks! Really liking the plugin so far!

But, one minor issue is our internal github enterprise install is not SSL and the repo in Visual Studio 2015 is http://, but the plugin converts all the links "Pull Request", "Pulse", "Graphs", "Issues" to https:// breaking the feature for us.

@Haacked
GitHub member
Haacked commented Jul 28, 2015

Ah! Yeah, we need to use the scheme of the Enterprise URL and not just hard-code it to https.

@Haacked Haacked self-assigned this Jul 29, 2015
@Haacked
GitHub member
Haacked commented Jul 29, 2015

I'll fix this.

@Jaben
Jaben commented Jul 29, 2015

Awesome! Thanks Phil!

@Haacked Haacked referenced this issue Jul 30, 2015
Merged

Handle Enterprise http urls #21

@Haacked Haacked added a commit that referenced this issue Jul 30, 2015
@Haacked Haacked Preserve HTTP scheme for enterprise repositories 
Fixes #13

We need to preserve the format of the origin for non github.com
repositories (such as GitHub Enterprise instances). Many of them are not
set up with HTTPS because they're behind a firewall etc.
 237ffc5
@Haacked Haacked added a commit that referenced this issue Jul 30, 2015
@Haacked Haacked Preserve HTTP scheme for enterprise repositories 
Fixes #13

We need to preserve the format of the origin for non github.com
repositories (such as GitHub Enterprise instances). Many of them are not
set up with HTTPS because they're behind a firewall etc.
 f401897
@Haacked Haacked added the bug label Jul 31, 2015
@shana shana closed this in #21 Aug 1, 2015
@shana shana modified the milestone: 1.0.12 Aug 13, 2015
@shana
shana commented Aug 13, 2015

Fix released in v1.0.12.1 (website and VS gallery)

@fabriciogs
fabriciogs commented Aug 14, 2015

Awesome! Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment