Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Release 2.4.2 "We Like Strings Too" #1475
Merged
Conversation
- Add test to validate that the UsageService writes all the data - Add test to validate that the MetricsService sends all the data - Move the usage tracker tests into a decent namespace and one single fixture
Fix metrics, take 2135413
Log things at appropriate levels
Previous unless you had called `GetRepository` on a `SimpleApiClient` instance, `IsEnterprise()` simply returned `false` without checking. Make sure we actually perform the check. Fixes #1473
…ot-detected Fix SimpleApiClient.IsEnterprise().
shana
added a commit
that referenced
this pull request
Feb 9, 2018
Release 2.4.2 "We Like Strings Too"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Includes PRs #1467, #1472, #1476
Note: Do not merge master into this branch.
Release notes