Skip to content

/ InversifyJS

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependencies #717

Merged
merged 22 commits into from Dec 15, 2017
Merged

Circular dependencies #717

merged 22 commits into from Dec 15, 2017

Conversation

@remojansen
Copy link
Member

@remojansen remojansen commented Dec 15, 2017

Description

Fixes incorrect circular dependencies errors

Related Issue

#677
#543

Motivation and Context

#677
#543

How Has This Been Tested?

CI

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
remojansen added 14 commits Dec 14, 2017
@remojansen
Docs improvements
Verified
This commit was signed with a verified signature.
remojansen Remo H. Jansen
GPG key ID: 384CABDF5EB0A29F Learn about signing commits
aebcdb7
@remojansen
Sollved incorrect circular dependencies errors
Verified
This commit was signed with a verified signature.
remojansen Remo H. Jansen
GPG key ID: 384CABDF5EB0A29F Learn about signing commits
Loading status checks…
3eea385
@remojansen
Preparing release
Verified
This commit was signed with a verified signature.
remojansen Remo H. Jansen
GPG key ID: 384CABDF5EB0A29F Learn about signing commits
Loading status checks…
dc238de
@remojansen
better naming for file and vars
Verified
This commit was signed with a verified signature.
remojansen Remo H. Jansen
GPG key ID: 384CABDF5EB0A29F Learn about signing commits
Loading status checks…
829ca64
@remojansen
Fixed issue in node 9.2.0
Verified
This commit was signed with a verified signature.
remojansen Remo H. Jansen
GPG key ID: 384CABDF5EB0A29F Learn about signing commits
Loading status checks…
36d42df
@remojansen
Disabled node latest until nodejs/node/issues/17684 is resolved
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f44058f
@remojansen
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4919cab
@remojansen
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a7551cf
@remojansen
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f979a17
@remojansen
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f64fe14
@remojansen
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aeb30e9
@remojansen
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e19e50f
@remojansen
Trying to fix stack issue
9d21636
@remojansen
Merge branch 'issue-677' of github.com:inversify/InversifyJS into iss…
Loading status checks…
58cd992 
…ue-677
@remojansen remojansen mentioned this pull request Dec 15, 2017
Closed
5 of 10 tasks complete
@remojansen
Copy link
Member Author

@remojansen remojansen commented Dec 15, 2017

Blocked by nodejs/node#17684
remojansen added 8 commits Dec 15, 2017
@remojansen
Update appveyor.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e2ba8d9
@remojansen
Trying to fix stack error
29eaa35
@remojansen
Merge branch 'circular-dependencies' of github.com:inversify/Inversif…
Loading status checks…
e3116b3 
…yJS into circular-dependencies
@remojansen
WIP
Loading status checks…
38ca109
@remojansen
Debug helper
Loading status checks…
dd4c01b
@remojansen
WIP
Loading status checks…
95282b6
@remojansen
Now that the circular dependency issue is fixed there is no need for …
a331631 
…so many versions of node
@remojansen
Removed console.log
Loading status checks…
cbbff82
@remojansen remojansen merged commit d015952 into master Dec 15, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@remojansen remojansen deleted the circular-dependencies branch Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@remojansen
You can’t perform that action at this time.