Skip to content

/ git-point

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to react-native 0.46.2 #43

Merged
merged 3 commits into from Jul 14, 2017
Merged

upgrade to react-native 0.46.2 #43

merged 3 commits into from Jul 14, 2017

Conversation

@peterlazar1993
Copy link
Contributor

@peterlazar1993 peterlazar1993 commented Jul 13, 2017

I have upgraded the dependency for react native to the latest one. I ran the app on iOS emulator and did not find any regressions.
@housseindjirdeh
Copy link
Member

@housseindjirdeh housseindjirdeh commented Jul 13, 2017 •
edited

Awesome awesome awesome, I'm so glad there were no issues with updating 🙌 . Thank you so much for this.

Two tiny things:

  1. could you please update the flow-bin to match the new version? 0.47.0
  2. don't forget to run yarn contributors:add to have yourself added to the contributor's list!

Will merge this in right after :)
Peter Lazar and others added 3 commits Jul 13, 2017
Peter Lazar @peterlazar1993
upgrade to react-native 0.46.2
0901523
@peterlazar1993
bump up flow to 0.47
c13a54e
@peterlazar1993
add to contributor list
c415efe
@peterlazar1993
Copy link
Contributor Author

@peterlazar1993 peterlazar1993 commented Jul 14, 2017

@housseindjirdeh done, I've rebased with upstream. Should be good to merge after you do a quick check.
@housseindjirdeh
Copy link
Member

@housseindjirdeh housseindjirdeh commented Jul 14, 2017

Looks perfect 🙌
@housseindjirdeh
housseindjirdeh approved these changes Jul 14, 2017
View changes
@housseindjirdeh housseindjirdeh merged commit 3edfdae into gitpoint:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housseindjirdeh housseindjirdeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@peterlazar1993 @housseindjirdeh
You can’t perform that action at this time.