nodejs/node

1 Pull request merged by 1 person

• Merged #18129 buffer: throw when filling with empty buffers Jan 17, 2018

41 Pull requests proposed by 27 people

• Proposed #18170 stream: use state.ending to see if stream called end() Jan 16, 2018
• Proposed #18174 [v8.x backport] src: add openssl-system-ca-path configure option Jan 16, 2018
• Proposed #18178 http: setEncoding error for incoming packets Jan 16, 2018
• Proposed #18191 Add Node Slack community to support options Jan 16, 2018
• Proposed #18196 Use uv_hrtime as tracing timestamp Jan 17, 2018
• Proposed #18211 stream: readable stream continues to read when pushing a empty string Jan 17, 2018
• Proposed #18212 deps: cherry-pick 0bcb1d6f from upstream V8 Jan 17, 2018
• Proposed #18215 buffer: coerce offset to integer Jan 17, 2018
• Proposed #18216 src: fix fs.write() externalized string handling Jan 17, 2018
• Proposed #18217 test: added input validation test for fchmod Jan 18, 2018
• Proposed #18220 [v8.x] module: add builtinModules Jan 18, 2018
• Proposed #18228 util: isDeepStrictEqual always returns false to compare WeakMap/WeakSet Jan 18, 2018
• Proposed #18237 doc: shell option for the execFile and execFileSync functions Jan 18, 2018
• Proposed #18239 stream: remove unreachable code Jan 18, 2018
• Proposed #18240 [v6.x backport] deps: ICU 60.2, 60.1, and 59.1 backports Jan 18, 2018
• Proposed #18247 assert: wrap original error in ifError Jan 19, 2018
• Proposed #18248 doc: document asserts Weak(Map|Set) behavior Jan 19, 2018
• Proposed #18250 benchmark: use destructuring and more Jan 19, 2018
• Proposed #18257 fix flaky net-connect-handle-econnrefused Jan 19, 2018
• Proposed #18258 doc: improve callback documentation of http2Stream.pushstream() Jan 19, 2018
• Proposed #18259 test: change assert message to default Jan 19, 2018
• Proposed #18260 deps: upgrade libuv to 1.19.1 Jan 19, 2018
• Proposed #18261 module: ignore package.json/ directories Jan 19, 2018
• Proposed #18263 test: fix flaky cluster unix socket test Jan 20, 2018
• Proposed #18264 stream: simplify `src._readableState` to `state` Jan 20, 2018
• Proposed #18266 stream: fix not calling cleanup() when unpiping all streams. Jan 20, 2018
• Proposed #18268 doc: document the collaborator nomination process Jan 20, 2018
• Proposed #18270 src: don't abort when package.json is a directory Jan 20, 2018
• Proposed #18271 doc: split CONTRIBUTING.md Jan 20, 2018
• Proposed #18272 build: make linters independent of local node Jan 20, 2018
• Proposed #18276 fs: use AliasedBuffer for fs_stats_field_array Jan 21, 2018
• Proposed #18277 test: improve fs error message test Jan 21, 2018
• Proposed #18278 stream: delete unused code Jan 21, 2018
• Proposed #18281 url: expose the WHATWG URL API globally Jan 21, 2018
• Proposed #18282 test: adds tests for vm invalid arguments Jan 21, 2018
• Proposed #18283 doc: `readable.push()` supports `undefined` in non-object mode Jan 21, 2018
• Proposed #18287 Revert "build,test: make building addon tests less fragile" - broken source tarballs Jan 22, 2018
• Proposed #18289 doc: improve http.request documentation Jan 22, 2018
• Proposed #18290 [v9.x] async_hooks: use typed array stack as fast path Jan 22, 2018
• Proposed #18291 domain, src: clean up domain-related code Jan 22, 2018
• Proposed #18292 win, build: fix intl-none option Jan 22, 2018

42 Issues closed by 19 people

• Closed #18296 URL.parse does not Jan 22, 2018
• Closed #17340 --inspect-brk does not work with ESM Jan 22, 2018
• Closed #18285 Better message for: SyntaxError: The requested module does not provide an export named 'default' Jan 22, 2018
• Closed #17913 unhandledRejection falls into infinite recursion Jan 21, 2018
• Closed #18242 Stack trace is incomplete with async/await Jan 21, 2018
• Closed #18267 Node cant find package.json file Jan 21, 2018
• Closed #18275 node-8.9.3 two immediate execution function error Jan 21, 2018
• Closed #17789 http_parser takes one byte to much, upgrade websockets Jan 21, 2018
• Closed #18273 zlib: the gzip header#os is weird in macos Jan 20, 2018
• Closed #18255 Support of linux files pointed by /dev/fd/XX as the scripts Jan 20, 2018
• Closed #18225 Latest libuv breaks node streams Jan 19, 2018
• Closed #18189 repl: strange behaviour in the last nightlies on Windows Jan 19, 2018
• Closed #18246 cipher.update outputs base64 falsely Jan 19, 2018
• Closed #18232 strange befavior about console.err,console.log on win10 Jan 19, 2018
• Closed #18243 InternalModuleReadFile and InternalReadModuleJSON crash if directory named package.json. Jan 19, 2018
• Closed #11805 console - writable property Jan 18, 2018
• Closed #12516 What are Node.js "Linked" modules? Jan 18, 2018
• Closed #18224 Different behavior between ASCII hex for SHA256 Jan 18, 2018
• Closed #18116 options.end of fs.ReadStream does not work when options.start is undefined. Jan 18, 2018
• Closed #13020 test: investigate flakiness of `parallel/test-async-wrap-getasyncid` Jan 18, 2018
• Closed #17629 doc - fs.open does not have an explanation for File Descriptor Jan 17, 2018
• Closed #17601 How to access placeholder tokens? Jan 17, 2018
• Closed #17916 fs module unable to write data to file Jan 17, 2018
• Closed #17980 [windows]dgram socket not receiving on network without internet connection Jan 17, 2018
• Closed #18024 $PREFIX/lib/node is being ignored for require Jan 17, 2018
• Closed #18036 util.inspect can throw when passed a Proxy Jan 17, 2018
• Closed #13877 Discussion/Tracking SnapshotCreator support Jan 17, 2018
• Closed #18160 fix flaky sequential/test-timers-set-interval-excludes-callback-duration Jan 17, 2018
• Closed #18195 gzip streams sometimes produce invalid gzip headers Jan 17, 2018
• Closed #18202 Does v9.4.0 support dynamic `import()`? Jan 17, 2018
• Closed #18014 fs.rmdir on Windows throws ENOENT instead of ENOTDIR Jan 17, 2018
• Closed #18204 takeHeapSnapshot in node inspect creates corrupted JSON Jan 17, 2018
• Closed #18128 Pass an empty buffer to Buffer.alloc filling will cause not responding and high CPU usage Jan 17, 2018
• Closed #18187 require.resolve does not respect changes to current working directory Jan 17, 2018
• Closed #16387 Cluster listen doesn't resolve UNIX domain socket paths relative to worker CWD Jan 17, 2018
• Closed #18185 index.js error in circular dependencies Jan 17, 2018
• Closed #18180 I try build node from git source in arm64 board, node-gyp could not compiling native addon modules. Jan 17, 2018
• Closed #18193 Investigate flaky parallel/test-dgram-multicast-set-interface Jan 16, 2018
• Closed #18183 Crash calling c# dll's method from native addon Jan 16, 2018
• Closed #17053 Removing the bench-* targets in makefile? Jan 16, 2018
• Closed #15477 Chrome devtools cannot group source files by folder on Windows Jan 16, 2018
• Closed #17359 Running Node.js benchmarks in the community CI Jan 15, 2018

34 Issues created by 28 people

• Opened #18294 missing end event in streams Jan 22, 2018
• Opened #18288 Feature request: url.join(baseUrl, ...others) Jan 22, 2018
• Opened #18284 MaxListenersExceededWarning in repl Jan 21, 2018
• Opened #18274 Delete file after createWriteStream raises no error when stream.write('whatever') Jan 20, 2018
• Opened #18269 investigate flaky parallel/test-tls-server-verify on Windows Jan 20, 2018
• Opened #18265 v8.deserialize on WebAssembly module fails with "Unable to deserialize cloned data" Jan 20, 2018
• Opened #18262 Bikeshedding question: new home for V8's GYP files? Jan 19, 2018
• Opened #18256 async_wrap,inspect: heap snapshot CHECKs in WrapperInfo Jan 19, 2018
• Opened #18254 Flaky test-benchmark-path Jan 19, 2018
• Opened #18253 Flaky test-vm-basic Jan 19, 2018
• Opened #18252 Flaky dgram-udp6-send-default-host Jan 19, 2018
• Opened #18251 Flaky http2-settings-flood Jan 19, 2018
• Opened #18249 Fragile/buggy implementation of ES module loading Jan 19, 2018
• Opened #18234 Flaky test test-http2-compat-expect-continue Jan 18, 2018
• Opened #18233 RFC: Per Package Loader Hooks Jan 18, 2018
• Opened #18231 Any way to decode a buffer containing hex into another buffer? Jan 18, 2018
• Opened #18230 require.resolve.paths(${built-in module id}) returns null Jan 18, 2018
• Opened #18229 Add an entry to the module loading paths dynamically Jan 18, 2018
• Opened #18227 util.isDeepStrictEqual would be better to return false to compare WeakMap/WeakSet Jan 18, 2018
• Opened #18223 SIGILL (Illegal Instruction / Failed DCHECK) in Debug build and SIGSEGV in Release when heapdumping Jan 18, 2018
• Opened #18218 Performance degradation when looping across character codes of a string starting in 8.3 Jan 18, 2018
• Opened #18208 Floating point value decoded incorrectly by buf.readDoubleBE() Jan 17, 2018
• Opened #18199 shell option for execFile and execFileSync in child_process module not documented Jan 17, 2018
• Opened #18198 Wrong v9.4.0 documentation for `ServerHttp2Stream#pushStream()` Jan 17, 2018
• Opened #18197 PSA: custom git command for landing PRs Jan 17, 2018
• Opened #18190 Investigate flaky sequential/test-async-wrap-getasyncid Jan 16, 2018
• Opened #18188 Coerce require `request` to a string. Jan 16, 2018
• Opened #18181 In writable stream, should we always set `state.errorEmitted` to true when executing `stream.emit('error')`? Jan 16, 2018
• Opened #18177 Is Windows Server 2012 (not 2012 R2) supported ? Jan 16, 2018
• Opened #18176 http2 sessions aren't cleaned up properly, server can't close Jan 16, 2018
• Opened #18175 NODE_COLORS env Jan 16, 2018
• Opened #18172 Unexpected call to `flush` after transform stream destruction Jan 16, 2018
• Opened #18171 Unexpected event ordering when destroying a readable stream Jan 16, 2018
• Opened #18169 Memory leak with http2 write() Jan 16, 2018

81 Unresolved conversations

Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.

• 66 new comments Open #18131 esm: provide named exports for all builtin libraries Jan 21, 2018
• 34 new comments Open #18109 [WIP] fs: add FD object to manage file descriptors Jan 19, 2018
• 26 new comments Open #17560 vm: add module support Jan 22, 2018
• 21 new comments Open #17615 assert: add error diffs Jan 19, 2018
• 21 new comments Open #18138 crypto: add support for AES-CCM Jan 22, 2018
• 16 new comments Open #17054 fs: partition readFile to avoid threadpool exhaustion Jan 20, 2018
• 15 new comments Open #18023 assert: adds rejects() and doesNotReject() Jan 21, 2018
• 14 new comments Open #17690 crypto: Expose the public key of a certificate & cert sha256 Jan 22, 2018
• 13 new comments Open #15015 module: revert checking for package.json before extensions Jan 22, 2018
• 9 new comments Open #14901 src, test: node internals' postmortem metadata Jan 20, 2018
• 9 new comments Open #17977 doc : being more explicit in the synopsis Jan 21, 2018
• 8 new comments Open #18145 stream: delete redundant code Jan 17, 2018
• 7 new comments Open #17921 `fs.existsSync` returns wrong value on windows if there are no permissions on the given file Jan 20, 2018
• 7 new comments Open #16646 tools: custom eslint autofix for inspector-check.js Jan 19, 2018
• 7 new comments Open #18156 esm: Implement package.json "esm": true flag for ES modules in ".js" files Jan 20, 2018
• 5 new comments Open #17600 Allow --perf-prof and --perf-basic-prof in NODE_OPTIONS Jan 20, 2018
• 5 new comments Open #18098 stream: check type and range of highWaterMark Jan 22, 2018
• 4 new comments Open #8871 zlib deflate results in a memory leak Jan 17, 2018
• 4 new comments Open #8897 Windows Container: fs.realpathSync() is broken on shared volumes Jan 18, 2018
• 4 new comments Open #17970 Be more explicit in doc/api/synopsis.md Jan 21, 2018
• 4 new comments Open #15752 HTTP/1 createServer() options to pass custom Request and Response classes Jan 22, 2018
• 4 new comments Open #16647 tools: auto fix custom eslint rule for crypto-check.js Jan 20, 2018
• 4 new comments Open #17417 domain: runtime deprecate MakeCallback Jan 19, 2018
• 4 new comments Open #17489 deps: update V8 to 6.4 Jan 22, 2018
• 4 new comments Open #17851 fs: migrate fs_event_wrap to internal/errors Jan 22, 2018
• 3 new comments Open #18163 flaky whatwg-url-properties Jan 16, 2018
• 3 new comments Open #15284 test,flaky: test-cli-node-options Jan 18, 2018
• 3 new comments Open #16601 Investigate flaky test-fs-readfile-tostring-fail on macOS Jan 20, 2018
• 3 new comments Open #16238 build: make gyp user defined variables lowercase Jan 20, 2018
• 3 new comments Open #16648 tools: auto fix custom eslint rule for prefer-assert-iferror.js Jan 19, 2018
• 3 new comments Open #18043 tools: non-Ascii linter for /lib only Jan 19, 2018
• 3 new comments Open #18089 n-api: add methods to open/close callback scope Jan 17, 2018
• 3 new comments Open #18158 src: delete proccess.env values set to undefined Jan 16, 2018
• 2 new comments Open #16317 parallel/test-http-pipeline-flood being flaky Jan 16, 2018
• 2 new comments Open #18101 win dll: parallel/test-child-process-exec-maxBuffer fails Jan 16, 2018
• 2 new comments Open #18146 fs.write does not work on external two-byte strings Jan 17, 2018
• 2 new comments Open #17817 Node addon which uses `std::unordered_set` will crash on Node.js 9.3.0 Jan 19, 2018
• 2 new comments Open #16772 flake: `sequential/test-inspector-stop-profile-after-done` Jan 19, 2018
• 2 new comments Open #8307 module: node aborts when package.json is a directory Jan 19, 2018
• 2 new comments Open #13144 timers: expose rearm() Jan 22, 2018
• 2 new comments Open #17523 Additional validation of tag length in AES GCM decryption Jan 22, 2018
• 2 new comments Open #14500 test/dgram: Add support for IPv6 link local scope IDs in received UDP datagrams Jan 20, 2018
• 2 new comments Open #16471 crypto: migrate DiffieHellman to internal/errors Jan 19, 2018
• 2 new comments Open #16502 process: add one-shot signal handler support Jan 19, 2018
• 2 new comments Open #16505 repl: runtime deprecate NODE_REPL_HISTORY_FILE Jan 19, 2018
• 2 new comments Open #16529 crypto, errors: Add CryptoError to internal/errors, update crypto.setEngine Jan 19, 2018
• 2 new comments Open #16534 test: fix flaky test-http-dns-error Jan 22, 2018
• 2 new comments Open #17372 src: refactor GetPeerCertificate Jan 20, 2018
• 2 new comments Open #17482 crypto: use non-deprecated v8::Object::Set Jan 20, 2018
• 2 new comments Open #17737 src: restore stdio on program exit Jan 18, 2018
• 2 new comments Open #17804 build,win: replace find-python subroutine with PYTHON variable Jan 19, 2018
• 2 new comments Open #17823 Backport: Set dynamic import callback Jan 17, 2018
• 2 new comments Open #17828 repl: refactor tests to not rely on timing Jan 20, 2018
• 1 new comment Open #4464 https server should allow changing credentials dynamically Jan 16, 2018
• 1 new comment Open #14158 doc: better document `--shared` build Jan 17, 2018
• 1 new comment Open #18090 meta: about the collaborator nomination process Jan 17, 2018
• 1 new comment Open #13254 Integrate C++ AsyncHooks Embedder API with native abstraction Jan 18, 2018
• 1 new comment Open #16658 When Node addon creates a new isolate, use it to execute JS code and let it triggers GC, it will crash Jan 19, 2018
• 1 new comment Open #9160 security,unix: audit use of process.env in lib/ for setuid binary Jan 19, 2018
• 1 new comment Open #7145 observed setImmediate and setTimeout execution order contradicts documentation Jan 21, 2018
• 1 new comment Open #11865 Missing stack traces from async functions after the first await Jan 22, 2018
• 1 new comment Open #12877 http: setting multiple headers could be more efficient Jan 22, 2018
• 1 new comment Open #14595 configure: fix type of arm_version Jan 19, 2018
• 1 new comment Open #16353 test: refactor BuildOptions func in tools/test.py Jan 19, 2018
• 1 new comment Open #16402 https: add extra options to Agent#getName() Jan 19, 2018
• 1 new comment Open #16568 http: process array headers _after_ setting up agent Jan 19, 2018
• 1 new comment Open #16652 tools: auto fix custom eslint rule for prefer-assert-methods.js Jan 19, 2018
• 1 new comment Open #16891 Add support for including GNU Gold linker's section ordering Jan 19, 2018
• 1 new comment Open #16939 doc: Update tools/icu/README.md Jan 19, 2018
• 1 new comment Open #17199 refactor `test-http-exceptions` file to use countdown Jan 19, 2018
• 1 new comment Open #17640 src: update trace event macros to v8 6.3 version Jan 19, 2018
• 1 new comment Open #17927 fs: create consistent behavior for fs module across platforms Jan 21, 2018
• 1 new comment Open #18059 [v8.x] deps: cherry-pick c3458a8 from upstream V8 Jan 21, 2018
• 1 new comment Open #18065 timers: add an internal [@@refresh()] function Jan 19, 2018
• 1 new comment Open #18066 timers: runtime-deprecate {un}enroll() Jan 20, 2018
• 1 new comment Open #18077 test: fix require-deps-deprecation for installed deps Jan 16, 2018
• 0 new comments Open #10838 Malformed "url" parameter in "Debugger.scriptParsed" event Jan 18, 2018
• 0 new comments Open #17143 domain migration to async_hooks Jan 22, 2018
• 0 new comments Open #15560 HTTP/2 createServer() options to pass custom Request and Response classes Jan 22, 2018
• 0 new comments Open #15773 [v6.x backport] repl: refactor `LineParser` implementation Jan 17, 2018
• 0 new comments Open #18126 wip: remove await that might be the source of the trouble... Jan 21, 2018