Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30805: Avoid race condition of self._debug in event loop #2490

Closed
wants to merge 1 commit into from
Closed

bpo-30805: Avoid race condition of self._debug in event loop #2490

wants to merge 1 commit into from

Conversation

william-gr
Copy link
Contributor

If a process is schedule to run in the event loop with debug disabled
and debug is then enabled before the process finishes it will result in
a traceback: log_debug undefined.

@william-gr
Avoid race condition of self._debug in event loop
db4d4e4 
If a process is schedule to run in the event loop with debug disabled
and debug is then enabled before the process finishes it will result in
a traceback: log_debug undefined.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@william-gr william-gr changed the title Avoid race condition of self._debug in event loop bpo-30805: Avoid race condition of self._debug in event loop Jun 29, 2017
@william-gr
Copy link
Contributor Author

CLA signed. I dont know how to update that tag.

Just prod the bot @the-knights-who-say-ni ?

@methane methane added needs backport to 3.6 type-bug An unexpected behavior, bug, or error labels Aug 3, 2017
methane
methane approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ned-deily ned-deily requested review from 1st1 and asvetlov June 8, 2018 20:33
1st1 added a commit to 1st1/cpython that referenced this pull request Jun 8, 2018
@1st1
bpo-30805: Avoid race condition with debug logging
ec8d562 
Supersedes python#2490
@1st1 1st1 mentioned this pull request Jun 8, 2018
Merged
@1st1
Copy link
Member

1st1 commented Jun 8, 2018

Closing this PR in favour of #7545 as we don't have time to iterate on this patch before 3.7.0rc1.

@1st1 1st1 closed this Jun 8, 2018
@miss-islington miss-islington mentioned this pull request Jun 8, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@1st1 @miss-islington
bpo-30805: Avoid race condition with debug logging (pythonGH-7545)
baa494e 
Supersedes python#2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
1st1 added a commit that referenced this pull request Jun 8, 2018
@1st1
bpo-30805: Avoid race condition with debug logging (GH-7545)
12f482e 
Supersedes #2490
@miss-islington miss-islington mentioned this pull request Jun 8, 2018
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@1st1 @miss-islington
bpo-30805: Avoid race condition with debug logging (pythonGH-7545)
09d9e9e 
Supersedes python#2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request Jun 8, 2018
@miss-islington @1st1
bpo-30805: Avoid race condition with debug logging (GH-7545)
21f4c78 
Supersedes #2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request Jun 8, 2018
@miss-islington @1st1
bpo-30805: Avoid race condition with debug logging (GH-7545)
234b53f 
Supersedes #2490
(cherry picked from commit 12f482e)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
awaiting merge type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@william-gr @the-knights-who-say-ni @1st1 @methane @brettcannon @Mariatta