Loading…
Update to CodeMirror 3 and start to ship our components #3232
4 participants
I should note that the move to CM3 fixed some bugs that were preventing us from fixing the dreaded focus-click bug. Yeah!
|
why remove the components command? Won't we still want to use this when we update the versions we use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
|
Since the diff is completely impenetrable and filled with irrelevant (to us) removals and additions, I guess the only way to 'review' this is to test it in actual use. Actual code review does not seem possible.
i don't know if my problem is related to this, but after i merged the CM3 branch i'm having trouble to get the "custom js buttons" in the toolbar. this are my files :
this are my files https://gist.github.com/epifanio/5477637
- reverting to master i got the custom js back
Just following up from IRC: this PR did not actually have any effect on the custom js mentioned above.
sorry for the noise ... was a path mismatch on my system, between different version of ipython
it works fine, js extension loaded correctly and the focus-click bug is no more here :)
jquery is not listed in the dependencies in bower.json
OK I have made all of the changes I know about: adding back the components fab function and added a README.md for notebook development.
Hum... lots of changes in 2 weeks, I would have preferred to be able to pitch in earlier.
I'll will re-do a suggestion I made earlier, which is to consider alternative to bower, which unlike bower allow to specify a tag or even a sha of a repository in the equivalent of component.json
Maintaining our own tagged codemirror branch totally goes against the point of have semantic version number and being able to specify any kind of version range. Also with this, if packager want to use another version, it is as difficult to install another version with bower than to close from the originial repository.
Unless I'm missing something..
We are not maintaining our own codemirror repo anymore, since we realized that bower cannot be used for everything
Since we have proven that bower cannot install everything (CodeMirror, highlight.js, pagedown, prettify, etc.), that repo has two separate installation mechanisms - bower.json and nonbower.json, which is handled identically, but manually, for packages bower cannot install. Since we know that we cannot use bower for everything, I don't see a good reason to add our own repos for the ones that bower can't handle. That would mean we are maintaining our own repo as a submodule to track an installed clone of our own repo that is itself not even our own code, just for a stupid tag.
Hey @ellisonbg,
This seem to break the linenumber that are now out of CM gutter. according to CM docs :
CodeMirror-lines
The visible lines. This is where you specify vertical padding for the editor content.
So was it really what you ment ? could we at least keep a padding-left/right : 4px ?
-
-
-
-
This commit adds the right versions of: * Bootstrap * Jquery * less.js * CodeMirror We should always use bower to manage these packages in the future. BUT, we are not yet using this version of jquery as we still rely on an older crazy-branch version of jquery.ui.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
CM3 introduced a number of changes to how various paddings are set. Because of how we change the line-height we had to set these back to the CM2 values. What a pain!
-
-
The main purpose of this branch is the update to CodeMirror 3 and ship it as a bower component. Because CodeMirror doesn't use proper semantic version tags, we have created a CodeMirror ipython fork. The sole purpose of this fork is for us to maintain properly named tags that bower can install from.
As a side effect of these changes, we are now shipping in place all bower components that we are using (bootstrap, less. codemirror, jquery). BUT, the version of jquery in components is not yet being used as we are still stuck with the old version attached to the nasty jquery.ui branch we ship. In a later PR, we will need to get rid of that jquery.ui branch (replace those capabilties with bootstrap) and then move to a stable version of jquery.ui that matches that of the jquery component depended upon by bootstrap.
The transition to CodeMirror 3 is a bit of a pain - lots of things broke. In particular the input cell styling, tooltip and completer broke. I think I have fixed it all, but we need to go over these things with a pixel-perfect eye - alignments of all input/output text - subtle padding/margin changes, etc.
This PR replaces PR #2944