Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
ipython does not work with python compiled with openssl in fips mode. #10615
Comments
|
Sounds OK to me, go ahead and make a PR :-) |
|
As best I can tell, sha1 is supported in FIPS mode, if that's true, let's use that, instead. We're not using this for a cryptographically secure purpose, and sha256 is a bit slower, and generates a much longer string, most of which we will throw away, anyway - since we take only the first 12 characters. Also, although it is used in a deprecated function, for now, md5 is also imported in IPython/utils/path.py. I created a bug to remove it for some future first time contributor. |
|
Why not "Just" Edit: ( |
|
|
|
Ad, but we can pad to 12 with 0s then. |
srinathgs
added a commit
to srinathgs/ipython
that referenced
this issue
Jul 12, 2017
|
|
srinathgs |
93aa9ad
|
|
@ivanov: I somehow missed this thread because of the whole hoard of notifications from my github subscriptions. I just verified |
srinathgs commentedMay 30, 2017
in fips mode, md5 is disabled. hence, ipython fails with
this error.
A fix is changing md5 to sha256 in
IPython/core/compilerop.pyin this line. I can raise a pull request if the change looks fine.