Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: ignore more VC++ artifacts #13208

Merged
merged 0 commits into from May 27, 2017
Merged

build: ignore more VC++ artifacts #13208

merged 0 commits into from May 27, 2017

Conversation

@refack
Copy link
Member

@refack refack commented May 24, 2017

Checklist
Affected core subsystem(s)

build,tools
@refack
Copy link
Member Author

@refack refack commented May 24, 2017

/cc @nodejs/platform-windows @nodejs/build
@refack refack requested a review from joshgav May 24, 2017
@refack refack self-assigned this May 24, 2017
@gibfahn
gibfahn approved these changes May 24, 2017
View changes
@gibfahn
Copy link
Member

@gibfahn gibfahn commented May 24, 2017

What does *.exe match in the top level?
@refack
Copy link
Member Author

@refack refack commented May 24, 2017

for all sort of scripts we need ./node to be resolvable
@gibfahn
Copy link
Member

@gibfahn gibfahn commented May 25, 2017

for all sort of scripts we need ./node to be resolvable

I thought all the scripts used Release\node.exe for windows
@refack
Copy link
Member Author

@refack refack commented May 25, 2017

I started using make lint
@cjihrig
cjihrig approved these changes May 25, 2017
View changes
@Fishrock123
Copy link
Member

@Fishrock123 Fishrock123 commented May 25, 2017

I started using make lint

Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows
@refack
Copy link
Member Author

@refack refack commented May 25, 2017 •
edited by gibfahn

I started using make lint
Sorry, what does that have to do with the above comment?

I thought all the scripts used Release\node.exe for windows

The commands in Makefile assume NODE ?= ./$(NODE_EXE), so if I want to enjoy them I need to either symlink the exe, or keep specifying NODE=...
P.S. I'm using MSYS make in a regular (non WSL) environment.
@jasnell
jasnell approved these changes May 25, 2017
View changes
@refack refack closed this May 27, 2017
@refack refack force-pushed the refack:ignore-vs-artifacts branch to c1a4b53 May 27, 2017
@refack refack merged commit c1a4b53 into nodejs:master May 27, 2017
@refack
Copy link
Member Author

@refack refack commented May 27, 2017

Landed c1a4b53
@refack refack deleted the refack:ignore-vs-artifacts branch May 27, 2017
jasnell added a commit that referenced this pull request May 28, 2017
@refack @jasnell
build: ignore more VC++ artifacts
4f4d5d2 
PR-URL: #13208
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@refack refack removed their assignment Jun 12, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
2 of 3 tasks
MylesBorins added a commit that referenced this pull request Jul 17, 2017
@refack @MylesBorins
build: ignore more VC++ artifacts
a354134 
PR-URL: #13208
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@cjihrig cjihrig

@gibfahn gibfahn

@joshgav joshgav

Assignees
No one assigned
Labels
build meta tools windows
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@refack @gibfahn @Fishrock123 @jasnell @cjihrig @MylesBorins @nodejs-github-bot