test,dgram: harden test-dgram-bind-shared-ports.js #13100

refack · 2017-05-18T15:26:33Z

add mustCall and mustNotCall to all callbacks
exit the processes instead of kill

Ref: #13055
Ref: #12999
Ref: #13526

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

dgram,cluster,test

refack · 2017-05-18T15:29:19Z

Stress: https://ci.nodejs.org/job/node-stress-single-test/nodes=freebsd10-64/1229/

gibfahn · 2017-05-18T15:47:21Z

FWIW you can run node-test-commit or node-stress-single-test on a branch of your fork of Node if you want.

refack · 2017-05-18T15:48:58Z

FWIW you can run node-test-commit or node-stress-single-test on a branch of your fork of Node if you want.

Thanks, I was vaguely aware of that, but was not sure...
Anyway this might mature into a real PR (maybe).

Trott · 2017-05-18T16:36:19Z

Sign in to view

    // an error is expected on the second worker
    process.send(`socket2:${err.code}`);
-  });
+    socket2.close(common.mustCall(() => {


FWIW, I think this will only fire in the second worker. The first worker doesn't get an error on socket2 (and it's the first worker we care about for socket2 because it actually binds to the port).

Starting to wonder if whatever complexity is required to make socket2.close() work isn't any greater than complexity that might be required to make port: 0 work for this test. :-|

refack · 2017-05-18T19:15:16Z

ork for this test. :-|

Is that a wink?

refack · 2017-05-18T22:45:36Z

CI: https://ci.nodejs.org/job/node-test-commit/9990/

refack · 2017-05-19T12:26:22Z

Found a bug when workers bind for port 0. Blocking until I fix it.

fhinkel · 2017-06-07T16:35:38Z

ping @refack can this be landed now that #13064 is closed?

refack · 2017-06-09T21:21:41Z

Landed in c9d45c4

refack · 2017-06-09T21:23:02Z

Extra sanity of master: https://ci.nodejs.org/job/node-test-commit-linuxone/6521/


        test: harden test-dgram-bind-shared-ports

* add `mustCall` and `mustNotCall` to all callbacks * added `known_issue` for port binding PR-URL: #13100 Refs: #13055 Refs: #12999 Refs: #13526 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MylesBorins · 2017-07-17T14:34:04Z

@refack could you please backport to v6.x?


        test: harden test-dgram-bind-shared-ports

* add `mustCall` and `mustNotCall` to all callbacks * added `known_issue` for port binding PR-URL: nodejs#13100 Refs: nodejs#13055 Refs: nodejs#12999 Refs: nodejs#13526 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

refack · 2017-07-17T16:12:40Z

@refack could you please backport to v6.x?

#14327


        test: harden test-dgram-bind-shared-ports

* add `mustCall` and `mustNotCall` to all callbacks * added `known_issue` for port binding PR-URL: #13100 Refs: #13055 Refs: #12999 Refs: #13526 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>


        test: harden test-dgram-bind-shared-ports

* add `mustCall` and `mustNotCall` to all callbacks * added `known_issue` for port binding Backport-PR-URL: #14327 PR-URL: #13100 Refs: #13055 Refs: #12999 Refs: #13526 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>


        test: harden test-dgram-bind-shared-ports

* add `mustCall` and `mustNotCall` to all callbacks * added `known_issue` for port binding Backport-PR-URL: #14327 PR-URL: #13100 Refs: #13055 Refs: #12999 Refs: #13526 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>


        test: harden test-dgram-bind-shared-ports

* add `mustCall` and `mustNotCall` to all callbacks * added `known_issue` for port binding Backport-PR-URL: #14327 PR-URL: #13100 Refs: #13055 Refs: #12999 Refs: #13526 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

refack added dgram work in progress (WIP) net test labels May 18, 2017

refack self-assigned this May 18, 2017

nodejs-github-bot added the test label May 18, 2017

Trott reviewed May 18, 2017

View changes

refack force-pushed the refack:13064 branch 3 times, most recently May 18, 2017

refack changed the title ~~[WIP] test balloon for 13064~~ test,dgram: harden test-dgram-bind-shared-ports.js May 18, 2017

refack added cluster and removed work in progress (WIP) net labels May 18, 2017

refack force-pushed the refack:13064 branch May 18, 2017

This was referenced May 19, 2017

test: replace port in cluster dgram reuse test #12901

Closed

test: track callback invocations #13010

Closed

refack added the work in progress (WIP) label May 19, 2017

refack added the blocked label May 19, 2017

refack referenced this pull request May 20, 2017

test: fix sequential test-net-connect-local-error #13064

Closed

3 of 3 tasks complete

jasnell approved these changes May 22, 2017

View changes

refack referenced this pull request Jun 7, 2017

cluster: workers can't share socket if created with port 0 then recreated with assigned port number #13526

Closed

refack changed the title ~~test,dgram: harden test-dgram-bind-shared-ports.js~~ cluster: enable `cluster` to share sockets when worker bind to port 0 Jun 7, 2017

refack closed this Jun 9, 2017

refack force-pushed the refack:13064 branch to c9d45c4 Jun 9, 2017

refack merged commit c9d45c4 into nodejs:master Jun 9, 2017

refack deleted the refack:13064 branch Jun 9, 2017

addaleax referenced this pull request Jun 10, 2017

v8.1.1 proposal #13598

Merged

refack removed their assignment Jun 12, 2017

gibfahn referenced this pull request Jun 15, 2017

Auditing for 6.11.1 #230

Closed

2 of 3 tasks complete

MylesBorins added backport-requested-v6.x labels Jul 17, 2017

refack referenced this pull request Jul 17, 2017

[v6.x backport] test: harden test-dgram-bind-shared-ports #14327

Closed

2 of 3 tasks complete

MylesBorins added backported-to-v6.x and removed backport-requested-v6.x labels Aug 14, 2017

MylesBorins referenced this pull request Aug 16, 2017

v6.11.3-proposal #14852

Merged

nodejs/node

test,dgram: harden test-dgram-bind-shared-ports.js #13100

test,dgram: harden test-dgram-bind-shared-ports.js #13100

refack commented May 18, 2017 •

edited

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

gibfahn commented May 18, 2017

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

refack commented May 19, 2017

This comment has been minimized.

fhinkel commented Jun 7, 2017

This comment has been minimized.

refack commented Jun 9, 2017

This comment has been minimized.

refack commented Jun 9, 2017

This comment has been minimized.

MylesBorins commented Jul 17, 2017

This comment has been minimized.

refack commented Jul 17, 2017

nodejs/node

Join GitHub today

test,dgram: harden test-dgram-bind-shared-ports.js #13100

Conversation

refack commented May 18, 2017 • edited

Checklist

Affected core subsystem(s)

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

gibfahn commented May 18, 2017

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

Trott May 18, 2017 • edited

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

refack commented May 18, 2017

This comment has been minimized.

refack commented May 19, 2017

This comment has been minimized.

fhinkel commented Jun 7, 2017

This comment has been minimized.

refack commented Jun 9, 2017

This comment has been minimized.

refack commented Jun 9, 2017

This comment has been minimized.

MylesBorins commented Jul 17, 2017

This comment has been minimized.

refack commented Jul 17, 2017

refack commented May 18, 2017 •

edited

Trott May 18, 2017 •

edited