node: improve invalid promiseRejectEvent message#12071
Closed
Fishrock123 wants to merge 1 commit into
Closed
Conversation
Or at least make an attempt to provide some useful information. I don't think it possible to encounter this in practice but it could happen in a future V8 upgrade, theoretically.
Fishrock123
added
process
jasnell
approved these changes
Mar 27, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
Having to do the for-in search is not ideal but if it's the only way.. LGTM
Contributor
Author
|
@jasnell |
Member
|
😢 ... yep. Ok, LGTM |
targos
approved these changes
Aug 20, 2017
Member
|
Is this actually something that could ever happen? How could a promise not be handled or unhandled? |
Member
|
@BridgeAR ... yes it can. If a rejected promise does not have a catch handler before it is garbage collected, etc |
Member
|
@jasnell I just checked and it is a enum with two values (check the v8::PromiseRejectEvent). This can never ever happen. |
Member
|
Interesting... ok, I'll take another look :-) Btw... really appreciate all the triage work you've been doing the past couple of days :-) |
Member
|
Closing due to mentioned reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or at least make an attempt to provide some useful information.
I don't think it possible to encounter this in practice but it could
happen in a future V8 upgrade, theoretically.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
node? process? promise? something like that