Exclude myself from mention-bot #529

Merged
merged 1 commit into from Mar 7, 2017

Projects

None yet

5 participants

Member
haypo commented Mar 7, 2017

I made changes in almost all CPython files last 5 years, so
mention-bot asks me to review basically all pull requests. I simply
don't have the bandwidth to review everything, sorry! I prefer to
select myself which PR I want to follow.

@haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dstufft and @Carreau to be potential reviewers.

Member
haypo commented Mar 7, 2017

I'm not sure if I should put my name in userBlacklist or userBlacklistForPR.

Member
haypo commented Mar 7, 2017

I'm not sure if I should put my name in userBlacklist or userBlacklistForPR.

I will follow Stefan Krah's example: put my GitHub login in both lists ;-)

Contributor
Carreau commented Mar 7, 2017

While you are at it can you add .mentionbot to the list of ignored files ?

Owner
dstufft commented Mar 7, 2017

@haypo You want to add yourself to userBlacklist.

Owner
dstufft commented Mar 7, 2017

userBlacklistForPR will stop the mention bot from mentioning anyone on your PRs.

@haypo haypo Exclude myself from mention-bot
I made changes in almost all CPython files last 5 years, so
mention-bot asks me to review basically all pull requests. I simply
don't have the bandwidth to review everything, sorry! I prefer to
select myself which PR I want to follow.
2eb88f6
Member
haypo commented Mar 7, 2017

@Carreau: "While you are at it can you add .mentionbot to the list of ignored files ?"

I don't see .mentionbot in "git status". What is your OS? What is the issue? :-)

Member
haypo commented Mar 7, 2017

@dstufft : "You want to add yourself to userBlacklist."

Oh ok, done :-)

Owner
dstufft commented Mar 7, 2017

@haypo he means to add .mention-bot to the list of blacklisted files inside of the .mention-bot file. I wouldn't do that though, I think it's useful ¯\_(ツ)_/¯

@dstufft
dstufft approved these changes Mar 7, 2017 View changes
Member
haypo commented Mar 7, 2017

"@haypo he means to add .mention-bot to the list of blacklisted files inside of the .mention-bot file. I wouldn't do that though, I think it's useful ¯_(ツ)_/¯"

Ah, please propose a PR for that @Carreau. At least, I will no more be be impacted once this change will be merged :-D

Contributor
Carreau commented Mar 7, 2017

Ah, please propose a PR for that @Carreau. At least, I will no more be be impacted once this change will be merged :-D

Understood, I'll make a PR and ping you manually everywhere, just to be sure you don't miss anything.

AraHaan commented Mar 7, 2017

heh, nice way to pick on him. 😛

@haypo haypo merged commit fea9676 into python:master Mar 7, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Member
haypo commented Mar 7, 2017

"Understood, I'll make a PR and ping you manually everywhere, just to be sure you don't miss anything."

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment